Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated getWithDefault for v4.0 #19620

Closed
wants to merge 35 commits into from
Closed

Remove deprecated getWithDefault for v4.0 #19620

wants to merge 35 commits into from

Commits on May 24, 2021

  1. [DOC] Link the templateOnly docs to the correct package

    This makes sure the `templateOnly` documentation appears in the right place.
    Windvis committed May 24, 2021
    Configuration menu
    Copy the full SHA
    41488b8 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. Merge pull request #19553 from Windvis/doc/template-only-doc-location

    [DOC] Link the `templateOnly` docs to the correct package
    rwjblue committed May 27, 2021
    Configuration menu
    Copy the full SHA
    7e57cec View commit details
    Browse the repository at this point in the history
  2. [BUGFIX lts] Ensures that computed can depend on dynamic hash keys

    Ensures that computeds can depend on dynamic hash keys that did not
    exist on the original hash.
    Chris Garrett committed May 27, 2021
    Configuration menu
    Copy the full SHA
    628a928 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #19565 from emberjs/bugfix/ensure-hash-works-with-…

    …computeds
    
    [BUGFIX lts] Ensures that computed can depend on dynamic hash keys
    rwjblue committed May 27, 2021
    Configuration menu
    Copy the full SHA
    b4ace38 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Extend transition deprecation

    btecu committed May 28, 2021
    Configuration menu
    Copy the full SHA
    926452f View commit details
    Browse the repository at this point in the history

Commits on May 29, 2021

  1. Merge pull request #19571 from btecu/transition-deprecaton

    [BUGFIX release] Extend transitionTo deprecation
    kategengler committed May 29, 2021
    Configuration menu
    Copy the full SHA
    cf7c1bd View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. Configuration menu
    Copy the full SHA
    42bd258 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2021

  1. Extract separate global deprecation helpers into standalone module.

    No logical changes here, just moving the code to detect and generate the
    message out into a stand alone module (makes it easier to reason about
    and possible to unit test).
    
    Co-authored-by: Stefan Penner <stefan.penner@gmail.com>
    rwjblue and stefanpenner committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    aef0c07 View commit details
    Browse the repository at this point in the history
  2. Add some basic tests

    Co-authored-by: Stefan Penner <stefan.penner@gmail.com>
    rwjblue and stefanpenner committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    540fafa View commit details
    Browse the repository at this point in the history
  3. Refactor @ember/-internals/bootstrap back into an IIFE

    Fixes a few things:
    
    * Ensures that Embroider has a consistent protocol for ensuring the
      global is bootstrapped
    * Allows our override code to be transpiled
    * Ensures that any bootstrapping tweaks force us out of "prebuilt" mode
      (allowing that customized bootstrap code to actually run)
    
    Co-authored-by: Stefan Penner <stefan.penner@gmail.com>
    rwjblue and stefanpenner committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    fffe619 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. [DOC] Add missing Helper class methods

    This adds the public `CoreObject` methods to the API docs of the `Helper` class.
    Windvis committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    6a46de6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c2bdbcf View commit details
    Browse the repository at this point in the history
  3. Refactor Overrides infrastructure, add more tests

    Also fixed a few minor errors in the message (wrong version number etc)
    
    Included a list of hardcoded known dormant addons (polyfills mostly) to make
    the suggestions more reliable.
    chancancode committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    35689f9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5ad6f79 View commit details
    Browse the repository at this point in the history
  5. Add v3.27.3 to CHANGELOG.md.

    rwjblue committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    c35fc14 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d4fb9fb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c73d4b5 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Add v3.28.0-beta.4 to CHANGELOG

    (cherry picked from commit e31720c)
    kategengler committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    b6948fb View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. Configuration menu
    Copy the full SHA
    fcf2a64 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #19596 from ctjhoa/patch-1

    [DOC release] Fix "Dormant" addon warning typo
    rwjblue committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    c3160f8 View commit details
    Browse the repository at this point in the history
  3. Add CHANGELOG for v3.27.4

    (cherry picked from commit fe32020)
    (cherry picked from commit 2392417)
    chancancode committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    ea322a3 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. [BIGFIX release] Fix <LinkTo> with nested children

    During bubbling, `event.target` may point to a child element whereas
    `event.currentTarget` always points to the element where the handler
    was attached, which is what we want here.
    
    Reported in a comment on #19546, though this may be a distinct issue
    from the original report as it was reported as a default-cancelling
    parent element interfering with the nested `<LinkTo>`, and this is
    the other way around.
    chancancode committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    57907a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1bcdc6f View commit details
    Browse the repository at this point in the history
  3. Add CHANGELOG for 3.27.5

    (cherry picked from commit 428e7a0)
    chancancode committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    c47d628 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. Fix Changelog formatting

    The different heading levels are causing issues for services that are trying to read and filter the changelog
    Turbo87 committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    1a6c964 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #19599 from Turbo87/patch-1

    Fix Changelog formatting
    rwjblue committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    588dccb View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. Fix spelling mistake

    stefanpenner committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    297cf58 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #19600 from emberjs/fix-typo

    Fix spelling mistake
    Chris Garrett committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    6c15a82 View commit details
    Browse the repository at this point in the history
  3. Add v3.28.0-beta.5 to CHANGELOG

    (cherry picked from commit 7de1e20)
    kategengler committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    55d012c View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. [BUGFIX lts] Ensure hash objects correctly entangle as dependencies v2

    The previous bugfixes to `{{hash}}` caused a change to the semantics of
    computed properties that depend on a hash. Specifically, because
    `{{hash}}` objects are now proxies, they are _constant_, never updating
    again after they are initially created. This is fine if you depend on
    an individual key in a hash, but breaks if you depend directly on the
    hash itself:
    
    ```js
    computed('hash.foo', function() {}) // this works
    
    computed('hash', function() {}) // this will no longer rerun
    ```
    
    This is used occasionally when you wish to depend on the dynamic keys
    of a dictionary, like so:
    
    ```js
    computed('hash', function() {
      let values = [];
    
      for (let key in this.hash) {
        values.push(hash[key]);
      }
    
      return values;
    })
    ```
    
    Notably, this is not a problem with autotracking, because autotracking
    will entangle the usage of these keys dynamically. So this is only a
    problem with legacy systems such as `computed` and `observer` which
    cannot dynamically add dependencies based on the function's runtime.
    
    To fix this, we need to determine if a dependency is a hash when a
    computed or an observer depends upon it, and then entangle all of its
    keys if it is. We do this whenever the value is the last value in the
    chain.
    Chris Garrett committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    03b20d8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #19584 from emberjs/bugfix/hash-computed-chains-only

    [BUGFIX lts] Ensure hash objects correctly entangle as dependencies v2
    Chris Garrett committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    dec26de View commit details
    Browse the repository at this point in the history
  3. Bump glob from 7.1.6 to 7.1.7

    Bumps [glob](https://github.com/isaacs/node-glob) from 7.1.6 to 7.1.7.
    - [Release notes](https://github.com/isaacs/node-glob/releases)
    - [Changelog](https://github.com/isaacs/node-glob/blob/master/changelog.md)
    - [Commits](isaacs/node-glob@v7.1.6...v7.1.7)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    7289a0b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5ce39d1 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Add 3.28.0-beta.6 to CHANGELOG

    (cherry picked from commit a01e11d)
    kategengler committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    297ab0e View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Configuration menu
    Copy the full SHA
    a10935a View commit details
    Browse the repository at this point in the history