Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX release] 3.27 deprecation metadata #19541

Merged
merged 2 commits into from May 12, 2021
+197 −77
Merged

[BUGFIX release] 3.27 deprecation metadata #19541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efd066c
[BUGFIX release] 3.27 deprecation metadata
chancancode May 11, 2021
566af49
[CLEANUP] Deprecations URL consistency
chancancode May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/index.js
View file
Open in desktop
Expand Up @@ -281,7 +281,7 @@ module.exports = {

if (targets.includes('ie 11')) {
this.ui.writeWarnLine(
'Internet Explorer 11 is listed in your compilation targets, but it will no longer be supported in the next major version of Ember. Please update your targets to remove IE 11 and include new targets that are within the updated support policy. For details on the new browser support policy, see:\n\n - The official documentation: http://emberjs.com/browser-support\n - the deprecation guide: https://emberjs.com/deprecations/v3.x#toc_3-0-browser-support-policy\n'
'Internet Explorer 11 is listed in your compilation targets, but it will no longer be supported in the next major version of Ember. Please update your targets to remove IE 11 and include new targets that are within the updated support policy. For details on the new browser support policy, see:\n\n - The official documentation: http://emberjs.com/browser-support\n - the deprecation guide: https://deprecations.emberjs.com/v3.x#toc_3-0-browser-support-policy\n'
);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/@ember/-internals/console/index.js
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@ import { LOGGER } from '@ember/deprecated-features';
const DEPRECATION_MESSAGE = 'Use of Ember.Logger is deprecated. Please use `console` for logging.';
const DEPRECATION_ID = 'ember-console.deprecate-logger';
const DEPRECATION_URL =
'https://emberjs.com/deprecations/v3.x#toc_use-console-rather-than-ember-logger';
'https://deprecations.emberjs.com/v3.x#toc_use-console-rather-than-ember-logger';
/**
@module ember
*/
Expand Down
6 changes: 3 additions & 3 deletions packages/@ember/-internals/glimmer/lib/component.ts
View file
Open in desktop
Expand Up @@ -687,7 +687,7 @@ const Component = CoreView.extend(
{
id: 'ember-views.event-dispatcher.mouseenter-leave-move',
until: '4.0.0',
url: 'https://emberjs.com/deprecations/v3.x#toc_component-mouseenter-leave-move',
url: 'https://deprecations.emberjs.com/v3.x#toc_component-mouseenter-leave-move',
for: 'ember-source',
since: {
enabled: '3.13.0-beta.1',
Expand All @@ -700,7 +700,7 @@ const Component = CoreView.extend(
{
id: 'ember-views.event-dispatcher.mouseenter-leave-move',
until: '4.0.0',
url: 'https://emberjs.com/deprecations/v3.x#toc_component-mouseenter-leave-move',
url: 'https://deprecations.emberjs.com/v3.x#toc_component-mouseenter-leave-move',
for: 'ember-source',
since: {
enabled: '3.13.0-beta.1',
Expand All @@ -713,7 +713,7 @@ const Component = CoreView.extend(
{
id: 'ember-views.event-dispatcher.mouseenter-leave-move',
until: '4.0.0',
url: 'https://emberjs.com/deprecations/v3.x#toc_component-mouseenter-leave-move',
url: 'https://deprecations.emberjs.com/v3.x#toc_component-mouseenter-leave-move',
for: 'ember-source',
since: {
enabled: '3.13.0-beta.1',
Expand Down
10 changes: 8 additions & 2 deletions packages/@ember/-internals/glimmer/lib/components/-link-to.ts
View file
Open in desktop
Expand Up @@ -1035,8 +1035,11 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
{
id: 'ember.built-in-components.reopen',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
until: '4.0.0',
url: 'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-reopen',
}
);

Expand All @@ -1060,8 +1063,11 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
{
id: 'ember.built-in-components.reopen',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
chancancode marked this conversation as resolved.
Show resolved Hide resolved
until: '4.0.0',
url: 'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-reopen',
}
);

Expand Down
10 changes: 8 additions & 2 deletions packages/@ember/-internals/glimmer/lib/components/-textarea.ts
View file
Open in desktop
Expand Up @@ -62,8 +62,11 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
{
id: 'ember.built-in-components.reopen',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
chancancode marked this conversation as resolved.
Show resolved Hide resolved
until: '4.0.0',
url: 'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-reopen',
}
);

Expand All @@ -87,8 +90,11 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
{
id: 'ember.built-in-components.reopen',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
until: '4.0.0',
url: 'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-reopen',
}
);

Expand Down
4 changes: 2 additions & 2 deletions packages/@ember/-internals/glimmer/lib/components/abstract-input.ts
View file
Open in desktop
Expand Up @@ -239,7 +239,7 @@ export function handleDeprecatedFeatures(
for: 'ember-source',
since: {},
until: '4.0.0',
url: 'https://emberjs.com/deprecations/v3.x#toc_ember-component-send-action',
url: 'https://deprecations.emberjs.com/v3.x#toc_ember-component-send-action',
}
);

Expand Down Expand Up @@ -270,7 +270,7 @@ export function handleDeprecatedFeatures(
for: 'ember-source',
since: {},
until: '4.0.0',
url: 'https://emberjs.com/deprecations/v3.x#toc_ember-component-send-action',
url: 'https://deprecations.emberjs.com/v3.x#toc_ember-component-send-action',
}
);

Expand Down
10 changes: 8 additions & 2 deletions packages/@ember/-internals/glimmer/lib/components/checkbox.ts
View file
Open in desktop
Expand Up @@ -181,8 +181,11 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
{
id: 'ember.built-in-components.reopen',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
until: '4.0.0',
url: 'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-reopen',
}
);

Expand All @@ -206,8 +209,11 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
{
id: 'ember.built-in-components.reopen',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
until: '4.0.0',
url: 'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-reopen',
}
);

Expand Down
24 changes: 20 additions & 4 deletions packages/@ember/-internals/glimmer/lib/components/internal.ts
View file
Open in desktop
Expand Up @@ -274,8 +274,12 @@ export function handleDeprecatedArguments(target: DeprecatingInternalComponentCo
deprecate(`Passing the \`@${name}\` argument to <${angle}> is deprecated.`, false, {
id: 'ember.built-in-components.legacy-arguments',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
until: '4.0.0',
url:
'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-arguments',
});

this.modernized = false;
Expand Down Expand Up @@ -356,8 +360,12 @@ export function handleDeprecatedAttributeArguments(
{
id: 'ember.built-in-components.legacy-attribute-arguments',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
until: '4.0.0',
url:
'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-attribute-arguments',
}
);

Expand Down Expand Up @@ -517,8 +525,12 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
{
id: 'ember.built-in-components.legacy-attribute-arguments',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
until: '4.0.0',
url:
'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-attribute-arguments',
}
);

Expand All @@ -530,8 +542,12 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
{
id: 'ember.built-in-components.legacy-attribute-arguments',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
until: '4.0.0',
url:
'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-attribute-arguments',
}
);

Expand Down
54 changes: 47 additions & 7 deletions packages/@ember/-internals/glimmer/lib/components/link-to.ts
View file
Open in desktop
Expand Up @@ -393,7 +393,6 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
['role', 'ariaRole'],

// LinkTo
'href',
'title',
'rel',
'tabindex',
Expand All @@ -402,6 +401,23 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {

handleDeprecatedEventArguments(LinkTo);

// @href
{
let superOnUnsupportedArgument = prototype['onUnsupportedArgument'];

Object.defineProperty(prototype, 'onUnsupportedArgument', {
configurable: true,
enumerable: false,
value: function onUnsupportedArgument(this: LinkTo, name: string): void {
if (name === 'href') {
assert(`Passing the \`@href\` argument to <LinkTo> is not supported.`);
} else {
superOnUnsupportedArgument.call(this, name);
}
},
});
}

// @tagName
{
let superOnUnsupportedArgument = prototype['onUnsupportedArgument'];
Expand Down Expand Up @@ -454,8 +470,12 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
{
id: 'ember.built-in-components.legacy-arguments',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
until: '4.0.0',
url:
'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-arguments',
}
);

Expand All @@ -472,8 +492,12 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
{
id: 'ember.built-in-components.legacy-arguments',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
until: '4.0.0',
url:
'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-arguments',
}
);

Expand Down Expand Up @@ -505,8 +529,12 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
{
id: 'ember.built-in-components.legacy-arguments',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
until: '4.0.0',
url:
'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-arguments',
}
);
} else {
Expand All @@ -519,8 +547,12 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
{
id: 'ember.built-in-components.legacy-arguments',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
until: '4.0.0',
url:
'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-arguments',
}
);

Expand All @@ -540,8 +572,12 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
{
id: 'ember.built-in-components.legacy-arguments',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
until: '4.0.0',
url:
'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-arguments',
}
);

Expand All @@ -556,8 +592,12 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
{
id: 'ember.built-in-components.legacy-arguments',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
until: '4.0.0',
url:
'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-arguments',
}
);
}
Expand Down
10 changes: 8 additions & 2 deletions packages/@ember/-internals/glimmer/lib/components/text-field.ts
View file
Open in desktop
Expand Up @@ -225,8 +225,11 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
{
id: 'ember.built-in-components.reopen',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
until: '4.0.0',
url: 'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-reopen',
}
);

Expand All @@ -250,8 +253,11 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
{
id: 'ember.built-in-components.reopen',
for: 'ember-source',
since: {},
since: {
enabled: '3.27.0',
},
until: '4.0.0',
url: 'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-reopen',
}
);

Expand Down
1 change: 1 addition & 0 deletions packages/@ember/-internals/glimmer/lib/environment.ts
View file
Open in desktop
Expand Up @@ -118,6 +118,7 @@ const VM_DEPRECATION_OVERRIDES: (DeprecationOptions & {
},
{
id: 'argument-less-helper-paren-less-invocation',
url: 'https://deprecations.emberjs.com/v3.x#toc_argument-less-helper-paren-less-invocation',
until: '4.0.0',
for: 'ember-source',
since: {
Expand Down
2 changes: 1 addition & 1 deletion packages/@ember/-internals/glimmer/lib/modifiers/action.ts
View file
Open in desktop
Expand Up @@ -223,7 +223,7 @@ class ActionModifierManager implements InternalModifierManager<ActionState, obje
{
id: 'ember-views.event-dispatcher.mouseenter-leave-move',
until: '4.0.0',
url: 'https://emberjs.com/deprecations/v3.x#toc_action-mouseenter-leave-move',
url: 'https://deprecations.emberjs.com/v3.x#toc_action-mouseenter-leave-move',
for: 'ember-source',
since: {
enabled: '3.13.0-beta.1',
Expand Down
6 changes: 3 additions & 3 deletions packages/@ember/-internals/glimmer/lib/utils/managers.ts
View file
Open in desktop
Expand Up @@ -22,7 +22,7 @@ export function setComponentManager(
{
id: 'deprecate-string-based-component-manager',
until: '4.0.0',
url: 'https://emberjs.com/deprecations/v3.x/#toc_component-manager-string-lookup',
url: 'https://deprecations.emberjs.com/v3.x/#toc_component-manager-string-lookup',
for: 'ember-source',
since: {
enabled: '3.8.0',
Expand All @@ -49,7 +49,7 @@ if (DEBUG) {
version === '3.13',
{
id: 'manager-capabilities.components-3-4',
url: 'https://emberjs.com/deprecations/v3.x#toc_manager-capabilities-components-3-4',
url: 'https://deprecations.emberjs.com/v3.x#toc_manager-capabilities-components-3-4',
until: '4.0.0',
for: 'ember-source',
since: {
Expand All @@ -67,7 +67,7 @@ if (DEBUG) {
version === '3.22',
{
id: 'manager-capabilities.modifiers-3-13',
url: 'https://emberjs.com/deprecations/v3.x#toc_manager-capabilities-modifiers-3-13',
url: 'https://deprecations.emberjs.com/v3.x#toc_manager-capabilities-modifiers-3-13',
until: '4.0.0',
for: 'ember-source',
since: {
Expand Down