[BUGFIX beta] [DEPRECATION] Deprecate @foo={{helper}}
#19499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
commented
Apr 20, 2021
packages/@ember/-internals/glimmer/tests/integration/helpers/custom-helper-test.js
Show resolved
Hide resolved
|
Hmm. Not sure what’s up with the failures. Did I do something wrong when I publish the packages? (They work locally) cc @rwjblue |
chancancode
force-pushed
the
deprecate-argument-less-helper-paren-less-invocation
branch
2 times, most recently
from
0e148ac
to
d551570
Compare
Per [RFC 496](https://github.com/emberjs/rfcs/blob/master/text/0496-handlebars-strict-mode.md#3-no-implicit-invocation-of-argument-less-helpers), this commit deprecates the implicit invocation of argument-less helpers and requires explicit parenthesis if: 1. Non-strict mode, AND 2. `helper` is a free variable (not `this.helper`, `@helper` or a local variable), AND 3. No arguments are provided to the helper, AND 4. It's in a component invocation's named argument position (not `<div id={{helper}}>` or `<Foo bar={{helper}}>`), AND 5. Not parenthesized (not `@foo={{(helper)}}`), AND 6. Not interpolated (not `@foo="{{helper}}"`). The cases in real apps where all of the above are true should be quite rare, as most helpers take at least one argument. This is probably not the most efficient/minimal changes to the compiler infrastructure, but I chose to optimize for making the change easier to remove/rollback (i.e. adding new nodes instead of changing existing ones) as we won't be needing this for very long. This also bumps `@glimmer/*` to latest which also brings in the bugfix commit glimmerjs/glimmer-vm#1293.
chancancode
force-pushed
the
deprecate-argument-less-helper-paren-less-invocation
branch
from
d551570
to
62e2816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per RFC 496, this commit deprecates the implicit invocation of argument-less helpers and requires explicit parenthesis if:
helperis a free variable (notthis.helper,@helperora local variable), AND
<div id={{helper}}>or<Foo bar={{helper}}>), AND@foo={{(helper)}}), AND@foo="{{helper}}").The cases in real apps where all of the above are true should be quite rare, as most helpers take at least one argument.
This is probably not the most efficient/minimal changes to the compiler infrastructure, but I chose to optimize for making the change easier to remove/rollback (i.e. adding new nodes instead of changing existing ones) as we won't be needing this for very long.
This also bumps
@glimmer/*to latest which also brings in the bugfix commit glimmerjs/glimmer-vm#1293.