Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] Allow passing a string literal to {{helper}} and {{modifier}} #19487

Merged
merged 1 commit into from Mar 30, 2021
Merged

[BUGFIX beta] Allow passing a string literal to {{helper}} and {{modifier}} #19487

merged 1 commit into from Mar 30, 2021

Commits on Mar 30, 2021

  1. [BUGFIX beta] Allow passing a string literal to {{helper}} and {{modi… 

    …fier}}

As per [RFC #432](https://github.com/emberjs/rfcs/blob/master/text/0432-contextual-helpers.md#invoking-contextual-modifiers)

However, dynamic string values are currently disallowed per earlier
framework team weekly meeting discussion to not make it harder for
Embroider to heuristically analyze the dynamic usages.

Eventually we will want to do the same for components as well, and
this AST transform would work there too.
    @chancancode
    chancancode committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    397d6b9 View commit details
    Browse the repository at this point in the history