[BUGFIX] Restore nested paths on run and computed #19464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Mar 17, 2021
These values were previously nested on `run` and `computed`, and were accessible from the _imported_ versions of those values due to the fact that they transformed to be the same as globals. They were used by a few different consumers, but were not intended to be used this way. This PR restores the previous behavior, but also deprecates it.
pzuraq
force-pushed
the
restore-nested-paths-on-run-and-computed
branch
from
a55fc9d
to
bf750e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These values were previously nested on
runandcomputed, and wereaccessible from the imported versions of those values due to the fact
that they transformed to be the same as globals. They were used by a few
different consumers, but were not intended to be used this way.
This PR restores the previous behavior, but also deprecates it.