Update current route in willChangeRoute during an intermediate transition #19450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Mar 7, 2021
There was a problem hiding this comment.
We chatted a little bit about this in discord this afternoon, I think the thing we decided was:
- Update
router_jsto add anisIntermediateTransitionto theInternalTransitionbase class - Once landed + released, update EmberRouter's
routeWillChangeto detect that value and setthis.currentRouteto that transitions.tovalue - Add some inline comments explaining why 😛
| @@ -548,7 +548,7 @@ class EmberRouter extends EmberObject { | |||
|
|
|||
| intermediateTransitionTo(name: string, ...args: any[]) { | |||
| this._routerMicrolib.intermediateTransitionTo(name, ...args); | |||
|
|
|||
|
Will need tildeio/router.js#321 and a then router bump |
sly7-7
changed the title
sly7-7
changed the title
sly7-7
force-pushed
the
test-for-19449
branch
2 times, most recently
from
9decf9d
to
222e5ad
Compare
rwjblue
approved these changes
Mar 7, 2021
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to follow @rwjblue comment.
Fixes #19449