Ensure query params are preserved through an intermediate loading state transition #19448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I've found a solution, I mean, at least something that makes this test pass, and not breaking the others. |
sly7-7
force-pushed
the
loading-state-qp-bug
branch
from
7f40e54
to
d6be504
Compare
sly7-7
force-pushed
the
loading-state-qp-bug
branch
from
d6be504
to
7dbeded
Compare
|
The issue is now (hopefully) fixed. This pr can be merged after a new router.js release, and bumped here. |
|
|
|
Updated to https://github.com/tildeio/router.js/releases/tag/v7.2.0 (which includes tildeio/router.js#319). |
rwjblue
changed the title
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rwjblue @rreckonerr I think I've reproduced a failing test that highlights #19307.
Let me know if it's correct (and not a 'false' failing). Then I don't know how to fix, either it's in ember or in the router microlib.
Fixes #19307