Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] Support observer keys with colons #19436

Merged
merged 1 commit into from
Mar 8, 2021
Merged

[BUGFIX beta] Support observer keys with colons #19436

merged 1 commit into from
Mar 8, 2021

Conversation

bertdeblock
Copy link
Member

Fixes #19343.

rwjblue
rwjblue approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally seems good to me, thanks for working on it!

I've pinged @pzuraq and @krisselden for review also...

@rwjblue rwjblue merged commit 81fac42 into emberjs:master Mar 8, 2021
@rwjblue
Copy link
Member

rwjblue commented Mar 8, 2021

Thanks!

@jaredgalanis jaredgalanis mentioned this pull request Mar 31, 2021
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

@pzuraq pzuraq pzuraq approved these changes

@krisselden krisselden Awaiting requested review from krisselden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Observers don't work if the key contains colon ':' characters
3 participants
@bertdeblock @rwjblue @pzuraq