Add deprecation for Route#disconnectOutlet
#19407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
pzuraq
requested changes
Feb 12, 2021
| @@ -4,6 +4,8 @@ import { | |||
| moduleFor, | |||
| strip, | |||
| } from 'internal-test-helpers'; | |||
| import { ExpectDeprecationFunc } from '../../../../../../internal-test-helpers/lib/ember-dev/deprecation'; | |||
There was a problem hiding this comment.
This should likely be added to the above imports from internal-test-helpers, and the ExpectDeprecationFunc type/interface should be exported from that package
packages/@ember/-internals/glimmer/tests/integration/application/debug-render-tree-test.ts
Outdated
Show resolved
Hide resolved
patocallaghan
force-pushed
the
patoc/disconnect-outlet-deprecation
branch
from
f9da995
to
a7f16ce
Compare
patocallaghan
force-pushed
the
patoc/disconnect-outlet-deprecation
branch
2 times, most recently
from
96a8a34
to
a34856e
Compare
rwjblue
approved these changes
Feb 24, 2021
patocallaghan
force-pushed
the
patoc/disconnect-outlet-deprecation
branch
from
a34856e
to
33979b8
Compare
|
@rwjblue I've resolved the conflict 🙇♂️ |
|
Thank you @patocallaghan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds deprecation for
Route#disconnectOutlet. See RFC 491 for more info.I was initially going to ship the
disconnectOutlet,renderandrenderTemplatedeprecations together in #19388 but the amount of tests which break and require aexpectDeprecationis a bit overwhelming and taking longer than expected 😅 I've decided to break this one out instead.