Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the internal Ember loader to use the standard Ember CLI loader #19390

Merged
merged 2 commits into from Feb 10, 2021

Commits on Feb 9, 2021

  1. Refactor the internal Ember loader to use the standard Ember CLI loader

    This PR refactors the internal Ember loader so that it uses the standard
    Ember CLI loader instead for modules. This means that modules will be
    defined in the main namespace, and importable from there, instead of in
    a hidden namespace that only Ember can use.
    
    Notes:
    
    - Code is still loaded and built via `treeForVendor` and included as a
      vendor file. This needs to be the case for the time being for
      bootstrapping.
    - Loader code is still included for Node support. If `define` and
      `require` are not already defined, then a backup shim is used instead.
    - Modules are now exposed from Ember, but `ember-cli-babel` still
      transpiles them to global references. This unblocks us from being able
      to make all modules work normally, however.
    - `require` shim module is no longer defined, we reference `define` and
      `require` as globals instead (which is more accurate). In the future
      we should update this to use Embroider's conventions.
    - `__loader` is still exposed on the Ember object, referencing the same
      values as before.
    NullVoxPopuli authored and Chris Garrett committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    be324d1 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. update to use require.entries

    Chris Garrett committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    f8eb312 View commit details
    Browse the repository at this point in the history