Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use qunit-dom in helper and component test blueprints #19384

Merged
merged 1 commit into from Feb 24, 2021
Merged

Use qunit-dom in helper and component test blueprints #19384

merged 1 commit into from Feb 24, 2021

Conversation

bertdeblock
Copy link
Member

No description provided.

@NullVoxPopuli
Copy link
Sponsor Contributor

how do we know if these tests pass right away? I know there is a smidgen difference between hasText and containsText, where hasText requires exact matches (trimmed, obvs) -- idk if that matters for this tho

@bertdeblock
Copy link
Member Author

@NullVoxPopuli Thanks for checking / approving. AFAICT, hasText is the right qunit-dom equivalent for the current assert.equal approach, which checks for an exact match as well (trimming unnecessary whitespace included). Regarding the fact if they pass or not, the correct output is tested, but I'm not sure if these files actually run as well during the test suite.

@rwjblue
Copy link
Member

rwjblue commented Feb 24, 2021

Thank you!

@rwjblue rwjblue merged commit 28c18d0 into emberjs:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants