Deprecate implicit this property lookup fallback
#19371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
deprecate-this-fallback
branch
2 times, most recently
from
a5b380a
to
c793a41
Compare
pzuraq
reviewed
Feb 2, 2021
Lands the deprecation proposed in [emberjs/rfcs#308](https://github.com/emberjs/rfcs/blob/master/text/0308-deprecate-property-lookup-fallback.md): The [no-implicit-this](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-implicit-this.md) template linting rule has been enabled for Ember applications by default since around Ember 3.16 (included in the `octane` preset). This PR will take that a step further and issue a deprecation for templates that are still using `{{foo}}` to mean `{{this.foo}}`. Note: It does provide for an easy way to temporarily disable the deprecation messages (e.g. to reduce console output to hone in on other issues). This is intended for sporadic usage while debugging **not** as a way to mitigate the deprecation (the fallback behavior will be removed in 4.0.0).
rwjblue
force-pushed
the
deprecate-this-fallback
branch
from
c793a41
to
7b628fc
Compare
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lands the deprecation proposed in emberjs/rfcs#308:
The no-implicit-this template linting rule has been enabled for Ember applications by default since around Ember 3.16 (included in the
octanepreset).This PR will take that a step further and issue a deprecation for templates that are still using
{{foo}}to mean{{this.foo}}.Note: It does provide for an easy way to temporarily disable the deprecation messages (e.g. to reduce console output to hone in on other issues). This is intended for sporadic usage while debugging not as a way to mitigate the deprecation (the fallback behavior will be removed in 4.0.0).