[DEPRECATION] Deprecates old browser support policy #19359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
deprecate-ie11
branch
from
1c36946
to
fa6e816
Compare
rwjblue
approved these changes
Jan 27, 2021
|
Will need to be updated to avoid issuing the deprecation on IE11 (or we need to make the "fail on deprecation" setup ignore this specific id). Also, seems like we have an issue in Node / SSR. The error that is being thrown seems wrong though (I suspect an earlier deprecation causes the assets to be loaded incorrectly, but haven't verified). |
rwjblue
force-pushed
the
deprecate-ie11
branch
from
fa6e816
to
fe48997
Compare
* Adds the deprecation specified in https://github.com/emberjs/rfcs/blob/master/text/0685-new-browser-support-policy.md * Updates the test harness to avoid failing CI for deprecations issued on IE11
rwjblue
force-pushed
the
deprecate-ie11
branch
from
fe48997
to
07357ed
Compare
|
Good bye IE11. You won't be missed 😄
|
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the deprecation specified in https://github.com/emberjs/rfcs/blob/master/text/0685-new-browser-support-policy.md