[RFC 445] Deprecate {{#with}}
#19346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also transforms `{{#with}}` into the equivalent combination of
`{{#let}}` and/or `{{#if}}` to allow removing the legacy upstream
code on the Glimmer VM side.
See [RFC 445](https://github.com/emberjs/rfcs/blob/master/text/0445-deprecate-with.md).
chancancode
commented
Jan 20, 2021
Comment on lines
+108
to
+115
| deprecate(`\`{{#with}}\` is deprecated. ${recommendation} ${sourceInformation}`, false, { | ||
| id: 'ember-glimmer.with-syntax', | ||
| until: '4.0.0', | ||
| for: 'ember-source', | ||
| since: { | ||
| enabled: '3.26.0-beta.1', | ||
| }, | ||
| }); |
There was a problem hiding this comment.
We'd need to add a url to the deprecation guide entry. This can probably be done post-merge and I'd like to hand that (writing the deprecation guide) off to someone else so I can focus on implementing other deprecation RFCs.
rwjblue
approved these changes
Jan 20, 2021
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also transforms
{{#with}}into the equivalent combination of{{#let}}and/or{{#if}}to allow removing the legacy upstream code on the Glimmer VM side.See RFC 445.