[RFC 674] Deprecate transition methods of controller and route #19255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
force-pushed
the
deprecatee-route-controller-transitions
branch
4 times, most recently
from
d3513d7
to
a7d014f
Compare
Route - transitionTo - replaceWith Controller - transitionToRoute - replaceRoute
locks
force-pushed
the
deprecatee-route-controller-transitions
branch
from
a7d014f
to
0901ef6
Compare
|
Ready to go! |
|
@rwjblue ping x) |
rwjblue
approved these changes
Jan 21, 2021
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements RFC #674 "Deprecate transition methods of controller and route".
Deprecation guide online.
I kept the original behavior in the tests and wrapped them in
expectDeprecationbecause I'm assuming there might be timing differences and whatnot, the purpose of the test is to exercise the specific API? Please let me know if I should adjust something.