[FEATURE modernized-built-in-components] First-pass implementation #19218

chancancode · 2020-10-20T06:40:39Z

First-pass implementation for converting the <Input> component into an internal (not classic) component compatibly. This passes all the existing tests.

Some follow-up work before this is ready for prime time:

Implement any remaining classic component features not covered by the existing tests.
Detect any unimplementable classic component features and deopt into the previous implementation.
Write the second deprecation RFC and get the proposal merged.

chancancode · 2020-10-27T06:37:38Z

This passes all the existing tests and is ready for review – at least it will be a useful starting point for some conversation. IMO the remaining work can be done in follow-up PRs. I'm also not sure whether we want to do a very rigious audit on what Ember.Component features or just do the main ones we know about and let people report bugs of any untested features. There are things like @tagName which technically works but I don't know that anyone would do that intentionally on the <Input> component (that is a more valid/expected thing to do to the <LinkTo> component, on the other hand).

chancancode · 2020-10-27T08:34:14Z

packages/@ember/-internals/glimmer/lib/components/input.ts

+            `Passing the \`@${argument}\` argument to <Input> is deprecated. ` +
+              `Instead, please pass the attribute directly, i.e. \`<Input ${attribute}={{...}} />\` ` +
+              `instead of \`<Input @${argument}={{...}} />\` or \`{{input ${argument}=...}}\`.`,
+            true /* TODO !(argument in this.args) */,


Actually enabling all these deprecations require fixing lots of tests, so leave them disabled for now.

packages/@ember/-internals/glimmer/lib/components/input.ts

packages/@ember/-internals/glimmer/lib/templates/input.hbs

rwjblue · 2020-11-09T21:39:32Z

packages/@ember/-internals/glimmer/lib/components/input.ts

+                  `the <Input> component and prevented it from functioning properly. ` +
+                  `Instead, please use the {{on}} modifier, i.e. \`<Input {{on "${eventName}" ...}} />\` ` +
+                  `instead of \`<Input @${methodName}={{...}} />\` or \`{{input ${methodName}=...}}\`.`,
+                true /* TODO !descriptor */,


Can you open an issue with some guidance and then link back to it from here? Basically, we need some path to enabling this deprecation...

rwjblue · 2020-11-09T21:42:19Z

packages/@ember/-internals/glimmer/lib/templates/input.hbs

+    {{!-- deprecated native event callbacks --}}
+    {{on "touchstart" this._touchStart}}
+    {{on "touchmove" this._touchMove}}
+    {{on "touchend" this._touchEnd}}
+    {{on "touchcancel" this._touchCancel}}
+    {{on "keydown" this._keyDown}}
+    {{on "keypress" this._keyPress}}
+    {{on "mousedown" this._mouseDown}}
+    {{on "mouseup" this._mouseUp}}
+    {{on "contextmenu" this._contextMenu}}
+    {{on "click" this._click}}
+    {{on "dblclick" this._doubleClick}}
+    {{on "focusin" this._focusIn}}
+    {{on "focusout" this._focusOut}}
+    {{on "submit" this._submit}}
+    {{on "dragstart" this._dragStart}}
+    {{on "drag" this._drag}}
+    {{on "dragenter" this._dragEnter}}
+    {{on "dragleave" this._dragLeave}}
+    {{on "dragover" this._dragOver}}
+    {{on "drop" this._drop}}
+    {{on "dragend" this._dragEnd}}
+    {{on "mouseenter" this._mouseEnter}}
+    {{on "mouseleave" this._mouseLeave}}
+    {{on "mousemove" this._mouseMove}}


We should either read the event dispatcher for its values here, or just defer to it

I actually wrote the code to address this and submitted #19269. However, as explained in that PR, I don't want to introduce a new global name for a one-off thing we are making here. Given that we expect the contextual modifier RFC to land pretty soon and this is still behind a flag, I would prefer to punt on addressing this for now.

First-pass implementation for converting the `<Input>` component into an internal (not classic) component compatibly. This passes all the existing tests. Some follow-up work before this is ready for prime time: - Implement any remaining classic component features not covered by the existing tests. - Detect any unimplementable classic component features and deopt into the previous implementation. - Write the second deprecation RFC and get the proposal merged.

…ation Tracking issue: emberjs#19270 More specifically, it enables the <Input> attribute deprecations introduced in emberjs#19218, fixes broken tests, and updates all test {{input}} invocations to use <Input> instead. Deprecate input arguments

…ation Tracking issue: https://github.com/emberjs/ember.js/issues/192t 70 More specifically, it enables the <Input> attribute deprecations introduced in emberjs#19218, fixes broken tests, and updates all test {{input}} invocations to use <Input> instead. WIP - add maybeExpectDeprecation function

…ation Tracking issue: emberjs#19270 More specifically, it enables the <Input> attribute deprecations introduced in emberjs#19218, fixes broken tests, and updates all test {{input}} invocations to use <Input> instead.

Tracking issue: emberjs#19270 Enables the input event handlers deprecation introduced in emberjs#19218 and fixes resultant failing tests

…nt handlers Tracking issue: emberjs#19270 Enables the input and textarea event handlers deprecation introduced in emberjs#19218 and fixes resultant failing tests

…nt handlers Tracking issue: #19270 Enables the input and textarea event handlers deprecation introduced in #19218 and fixes resultant failing tests

…ation Tracking issue: emberjs#19270 More specifically, it enables the <Input> attribute deprecations introduced in emberjs#19218, fixes broken tests, and updates all test {{input}} invocations to use <Input> instead.

…nt handlers Tracking issue: emberjs#19270 Enables the input and textarea event handlers deprecation introduced in emberjs#19218 and fixes resultant failing tests

chancancode force-pushed the refactor-input-component branch 5 times, most recently from c13355a to 656f72f Compare October 27, 2020 06:33

chancancode changed the title ~~[FEATURE modernized-built-in-components] WIP implementation~~ [FEATURE modernized-built-in-components] First-pass implementation Oct 27, 2020

chancancode marked this pull request as ready for review October 27, 2020 06:34

chancancode force-pushed the refactor-input-component branch 2 times, most recently from 63f6024 to c403f53 Compare October 27, 2020 07:20

chancancode commented Oct 27, 2020

View reviewed changes

chancancode force-pushed the refactor-input-component branch from c403f53 to e1e6424 Compare October 27, 2020 08:35

rwjblue reviewed Nov 9, 2020

View reviewed changes

chancancode mentioned this pull request Nov 14, 2020

[INTERNAL] Introduce InternalModifier #19269

Merged

chancancode force-pushed the refactor-input-component branch from e1e6424 to 411f95a Compare November 14, 2020 04:00

chancancode mentioned this pull request Nov 14, 2020

[FEATURE modernized-built-in-components] Tracking Issue #19270

Closed

16 tasks

chancancode force-pushed the refactor-input-component branch from 411f95a to 5ad99e7 Compare January 21, 2021 09:35

chancancode added 2 commits January 21, 2021 21:37

Skip strict mode input test for now

27a413f

chancancode force-pushed the refactor-input-component branch from 8b08f66 to 27a413f Compare January 22, 2021 05:37

pzuraq approved these changes Jan 28, 2021

View reviewed changes

pzuraq merged commit 0f49c4e into master Jan 28, 2021

pzuraq deleted the refactor-input-component branch January 28, 2021 22:49

eramod mentioned this pull request Feb 4, 2021

[FEATURE modernized-built-in-components] Implement input attrs deprecations #19380

Merged

eramod mentioned this pull request Feb 10, 2021

[FEATURE modernized-built-in-components] Enable input event handlers #19391

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE modernized-built-in-components] First-pass implementation #19218

[FEATURE modernized-built-in-components] First-pass implementation #19218

chancancode commented Oct 20, 2020 •

edited

chancancode commented Oct 27, 2020

chancancode Oct 27, 2020

rwjblue Nov 9, 2020

chancancode Nov 14, 2020

rwjblue Nov 9, 2020

chancancode Nov 14, 2020

chancancode Feb 5, 2021

[FEATURE modernized-built-in-components] First-pass implementation #19218

[FEATURE modernized-built-in-components] First-pass implementation #19218

Conversation

chancancode commented Oct 20, 2020 • edited

chancancode commented Oct 27, 2020

chancancode Oct 27, 2020

Choose a reason for hiding this comment

rwjblue Nov 9, 2020

Choose a reason for hiding this comment

chancancode Nov 14, 2020

Choose a reason for hiding this comment

rwjblue Nov 9, 2020

Choose a reason for hiding this comment

chancancode Nov 14, 2020

Choose a reason for hiding this comment

chancancode Feb 5, 2021

Choose a reason for hiding this comment

chancancode commented Oct 20, 2020 •

edited