[ci skip]

(cherry picked from commit 2b58f7a)

[BUGFIX beta] Fix substate interactions with aborts

(cherry picked from commit a968069)

[ci skip]

[ci skip]

(cherry picked from commit dd7a199)

This fixes emberjs#17243 by only removing dependent keys in `teardown`.

Since emberjs#16978 coalesces the work to add dependent keys to happen at
most once, it is now incorrect to eagerly remove them in `didUnwatch`
because that could happen for a variety of reasons while there are
still other interested parties (see attached test cases).

This limits the work of removing dependent keys to `teardown` only.
The logic is that, while we want to defer setting up the "link" to
the target property as lazily as possible, it is less important to
"unlink" it eagerly once the work is done. It _may_ be possible to
accomplish this, but the current amount of book-keeping is not
sufficient to track the count properly. In our tests, we have
created sequences like this:

1. setup (peekWatching = 0, so nothing happens)
2. get (consumed here)
3. willWatch (already consumed, no-op)
4. get (already consumed, no-op)
5. didUnwatch
6. ...

In this case, it would be incorrect to "unlink" at step 5. As of
PR emberjs#16978, `CONSUMED` is essentially a boolean flag, so it is not
sufficient to track the balance, and also, there is no counterpart
to `get`, which makes eager "unlinking" impossible without much
more book-keeping. It's unclear that it would be worthwhile to do
that.

On the other hand, if we only "unlink" on teardown, this ensures
that we are only "unlinking" at most once, and it is guaranteed
that there are no longer any interested parties.

Fixes emberjs#17243

Co-authored-by: Godfrey Chan <godfreykfc@gmail.com>
(cherry picked from commit 1f8218b)

Don't remove dep keys in `didUnwatch`

Fixes a few issues:

* Usage of positional arguments with custom components.
* Forwarding attributes via `...attributes` to a dynamic
  component.
* Prevent errors when rendering many template blocks
  (`Error: Operand over 16-bits. Got 65536`).

Full changes here:

glimmerjs/glimmer-vm@v0.37.0...v0.37.1
(cherry picked from commit 7600d7b)

…nent invoked with angle-bracket syntax that receives splattributes

(cherry picked from commit 2d1f8d0)
(cherry picked from commit 7eca43f)

…warded.

(cherry picked from commit 4073c1a)
(cherry picked from commit 8a99c8a)

…anagers

(cherry picked from commit 5639352)
(cherry picked from commit 9ce961a)

…nstead of String.prototype extensions

(cherry picked from commit 37d69f1)

(cherry picked from commit 58f3bec)

[ci skip]