Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (failing) tests for positional params with custom component managers #17483

Conversation

dfreeman
Copy link
Contributor

@rwjblue has opened glimmerjs/glimmer-vm#900 to fix the underlying issue with positional parameters for custom component managers, but suggested it would be helpful to have test coverage on the Ember side as well.

The tests here are pretty straightforward conversions of the two above them that test named args. I've confirmed that these pass when I apply the change from that PR to opcode-builder locally.

@rwjblue
Copy link
Member

rwjblue commented Jan 22, 2019

Thank you for working on this @dfreeman! I pulled your commit into #17499 (along with the fix). The fix lands in:

  • 3.4.8 (released today)
  • 3.7.2 (released today)
  • 3.8.0-beta.3 (should be released 2019-01-28)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants