Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Implements the Computed Property Modifier deprecation RFCs #17470

Merged
merged 2 commits into from Jan 17, 2019
Merged

[FEAT] Implements the Computed Property Modifier deprecation RFCs #17470

merged 2 commits into from Jan 17, 2019

Commits on Jan 11, 2019

  1. [FEAT] Implements the Computed Property Modifier deprecation RFCs 

    - Deprecates `.property()`
- Deprecates `.volatile()`
- Deprecates `clobberSet` internally
- Keeps injected properties and the `store` property on routes
  overridable for testing purposes
- Rewrites lots of usages in tests. For some reason `volatile` was
  frequently used in tests when it was not needed.
- Adds `additionalDependentKeys` array to `map`, `filter` and `sort`
  array functions. `sort` was overlooked in RFC, but suffers from the
  same problem so it shouldn't need an additional RFC.
- Adds tests for `additionalDependentKeys`
    Chris Garrett committed Jan 11, 2019
    Copy the full SHA
    f3693d6 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2019

  1. review feedback

    Chris Garrett committed Jan 12, 2019
    Copy the full SHA
    95973cf View commit details
    Browse the repository at this point in the history