Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get() / set() perf optimizations #17166

Merged
merged 5 commits into from Jan 2, 2019
Merged

get() / set() perf optimizations #17166

merged 5 commits into from Jan 2, 2019

Commits on Jan 2, 2019

  1. Use null to distinguish between missing or empty meta param 

    This avoids redundant peeking when passing empty meta to certain methods
    @kanongil @rwjblue
    kanongil authored and rwjblue committed Jan 2, 2019
    Copy the full SHA
    1eb257e View commit details
    Browse the repository at this point in the history

  2. Use Map() for descriptor store

    @kanongil @rwjblue
    kanongil authored and rwjblue committed Jan 2, 2019
    Copy the full SHA
    5cf6543 View commit details
    Browse the repository at this point in the history

  3. Only call split() once and avoid a join() for setPath()

    @kanongil @rwjblue
    kanongil authored and rwjblue committed Jan 2, 2019
    Copy the full SHA
    a51c182 View commit details
    Browse the repository at this point in the history

  4. Resolve path names correctly

    @kanongil @rwjblue
    kanongil authored and rwjblue committed Jan 2, 2019
    Copy the full SHA
    cbbc4c4 View commit details
    Browse the repository at this point in the history

  5. Linting fixes

    @kanongil @rwjblue
    kanongil authored and rwjblue committed Jan 2, 2019
    Copy the full SHA
    89acaf9 View commit details
    Browse the repository at this point in the history