Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX lts] build: Turn off sourcemaps for TS-to-ES compilation #17128

Merged
merged 3 commits into from
Oct 18, 2018
Merged

[BUGFIX lts] build: Turn off sourcemaps for TS-to-ES compilation #17128

merged 3 commits into from
Oct 18, 2018

Commits on Oct 18, 2018

  1. Add Node.js test asserting on the number of sourcemap comments in fin… 

    …al assets
    @Turbo87
    Turbo87 committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    dd36e9a View commit details
    Browse the repository at this point in the history

  2. build: Turn off sourcemaps for TS-to-ES compilation 

    We seem to use Babel to compile ES to AMD modules and that now includes ES modules there were originally written in TypeScript. The TypeScript compiler is apparently outputting sourcemaps by default, but it looks like Babel can't handle those properly. Instead Babel keeps the sourcemap comments inside of the AMD modules, which causes the final concatenated file to have *multiple* sourcemap comments, which is invalid. Future versions of Babel might fix this but for now we should turn off the TypeScript sourcemaps, so that the final build output is valid again.
    @Turbo87
    Turbo87 committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    fcd862a View commit details
    Browse the repository at this point in the history

  3. CI: Use EMBER_ENV=production for Node.js tests

    @Turbo87
    Turbo87 committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    4ae81b7 View commit details
    Browse the repository at this point in the history