[CLEANUP] Allow routes to be named "array" and "object" #16877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Aug 11, 2018
| @@ -26,7 +26,7 @@ class DSL { | |||
| return true; | |||
| } | |||
|
|
|||
| return ['array', 'basic', 'object', 'application'].indexOf(name) === -1; | |||
| return ['basic', 'object', 'application'].indexOf(name) === -1; | |||
There was a problem hiding this comment.
Can you also remove object? It was essentially the same boat as array and should die too...
camerondubas
changed the title
|
@rwjblue Updated |
|
All green, thank you! |
|
Thank you @camerondubas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all 👋 this is my first PR to Ember!
This resolves #16872 by removing "array" as a reserved route name.