[WIP] Update ember-cli #16459
Closed
[WIP] Update ember-cli #16459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
related RFCs: |
rwjblue
reviewed
Apr 3, 2018
| @@ -17,10 +17,6 @@ module.exports = useTestFrameworkDetector({ | |||
| testFolderRoot = pathUtil.getRelativeParentPath(options.entity.name, -1, false); | |||
| } | |||
|
|
|||
| let destroyAppExists = fs.existsSync( | |||
There was a problem hiding this comment.
Hmm, I think this still needs to exist no? This isn't about the ember-cli version that is being used by ember-source, but rather about the current project layout when the blueprint is ran...
There was a problem hiding this comment.
You're right, thanks for pointing this out. I enjoy deleting code so much, I just jumped right in 🙈
|
I'm going to close this and revisit in the morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pins ember-cli to include ember-cli/ember-cli#7731 so that we can implement more generator blueprints in ember-cli/ember-cli#7530
TODO: