Module-unification component blueprint #16043
Conversation
|
CI failure is due to eslint not being able to parse our templating, I believe we need to disable eslint from running on |
package.json
Outdated
| @@ -94,7 +94,7 @@ | |||
| "chalk": "^2.3.0", | |||
| "common-tags": "^1.4.0", | |||
| "dag-map": "^2.0.2", | |||
| "ember-cli": "2.10.0", | |||
| "ember-cli": "github:ember-cli/ember-cli", | |||
There was a problem hiding this comment.
project.isModuleUnification() was just recently merged to master
blueprints/component/index.js
Outdated
| return { | ||
| __root__(options) { | ||
| if (isModuleUnification) { |
There was a problem hiding this comment.
I think this check will break --dummy and --in-repo-addon cli flags. So if we have a module unification layout then
ember g component some-component --dummy
will generate component in the src/ instead of dummy/ dir.
There was a problem hiding this comment.
Hm... I've just realized that dummy apps has to support module unification layout as well 🤔
There was a problem hiding this comment.
Thanks, yes. I have an Add support for addons todo item above and I've asked a question on #st-module-unification looking for an example MU addon so that I can add support for it
GavinJoyce
changed the title
|
This ready for review. There is one small remaining item to point at the next beta release of ember-cli whenever it's released |
package.json
Outdated
| @@ -100,7 +100,7 @@ | |||
| "chalk": "^2.3.0", | |||
| "common-tags": "^1.7.2", | |||
| "dag-map": "^2.0.2", | |||
| "ember-cli": "2.18.0", | |||
| "ember-cli": "github:ember-cli/ember-cli", | |||
There was a problem hiding this comment.
do we want to keep this?
There was a problem hiding this comment.
no, ideally we'll update this to the next ember cli beta (it's the sole outstanding todo item on this PR)
There was a problem hiding this comment.
sorry I read what was written but didn't understand properly.
the work looks good 😃
GavinJoyce
changed the title
package.json
Outdated
| @@ -100,7 +100,7 @@ | |||
| "chalk": "^2.3.0", | |||
| "common-tags": "^1.7.2", | |||
| "dag-map": "^2.0.2", | |||
| "ember-cli": "2.18.0", | |||
| "ember-cli": "github:ember-cli/ember-cli#6a85734c52d129fc0824ec3fbf21bd01f9c9fa38", | |||
There was a problem hiding this comment.
I can't point to 3.1.0-beta.1 as intended as experiments are removed from betas and releases. Pointing to ember-cli/ember-cli@6a85734 instead
|
Hm, there seems to be some failing tests around differences with |
GavinJoyce
changed the title
|
There are a couple of things preventing me from currently upgrading to ember-cli
Some options:
/cc @mixonic as you were keen for me to add the experiment check in |
GavinJoyce
changed the title
|
We discussed this at the MU strike team meeting this week. The SHA pinned in this PR is before several changes where made to Ember-CLI that seem to break the Ember blueprints. I'm worried that breakage could be impacting real apps (on Canary if not anything stable) when using generators. However that breakage is not related to what @GavinJoyce has been digging into here. This looks great and is wholly behind a feature flag. Let's continue to iterate in master. Thanks @GavinJoyce! |
| @@ -6,6 +6,7 @@ const isPackageMissing = require('ember-cli-is-package-missing'); | |||
| const getPathOption = require('ember-cli-get-component-path-option'); | |||
|
|
|||
| const useTestFrameworkDetector = require('../test-framework-detector'); | |||
| const { isModuleUnificationProject } = require('../module-unification'); | |||
There was a problem hiding this comment.
Thanks @ro0gr, I'll update now
Part of ember-cli/ember-cli#7530
This PR adds initial support for
ember g component foo-barfrom a module unification app.TODO:
project.isModuleUnification()fix test failures since updating to the laters ember-cli(see Module-unification component blueprint #16043 (comment))QUESTIONS:
component-test.js) (update: [wip] added example tests stonecircle/mu-first-post#1)--pathoption? update: correct, we don't need to support it3.1.0-beta.1update: see Module-unification component blueprint #16043 (comment)USEFUL LINKS: