Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated support for mutation after consumption during certain manager hooks #1330

Merged
merged 2 commits into from Sep 22, 2021

Conversation

snewcomer
Copy link
Contributor

@snewcomer snewcomer commented Aug 29, 2021

This PR removes supporting infrastructure for allowing, but deprecating read after write in components and modifiers. Going forward, this will error with a message that you attempted to read then write in the same transaction.

Ref Ember.js issue: emberjs/ember.js#19617

Ember.js PR: emberjs/ember.js#19735

let end = nthIndex(e.stack, '\n', 4, updateStackBegin);
e.stack = e.stack.substr(0, start) + e.stack.substr(end);
}
// This hack makes the assertion message nicer, we can cut off the first
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this PR, but I wonder what is going on here -- why are we cutting of parts of the error message? are those parts ever needed?

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice
image

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rwjblue rwjblue changed the title [cleanup]: Remove mutation after consumption autotracking.mutation-after-consumption Remove deprecated support for mutation after consumption during certain manager hooks Sep 22, 2021
@rwjblue rwjblue merged commit 2dc926f into glimmerjs:master Sep 22, 2021
@snewcomer snewcomer deleted the sn/deprecate-tracking branch September 22, 2021 19:45
rwjblue added a commit to emberjs/ember.js that referenced this pull request Sep 27, 2021
High level breaking changes:

* `@glimmer/integration-tests`, `@glimmer/manager`, `@glimmer/validator`
  * [#1330](glimmerjs/glimmer-vm#1330) Remove deprecated support for mutation after consumption during certain manager hooks ([@snewcomer](https://github.com/snewcomer))
* `@glimmer/manager`
  * [#1328](glimmerjs/glimmer-vm#1328) Remove deprecated Component Manager version 3.4 ([@nlfurniss](https://github.com/nlfurniss))
* `@glimmer/integration-tests`, `@glimmer/manager`
  * [#1329](glimmerjs/glimmer-vm#1329) Remove deprecated Modifier Manager version 3.13 ([@nlfurniss](https://github.com/nlfurniss))

See full details here:

https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.81.0
rwjblue added a commit to emberjs/ember.js that referenced this pull request Sep 29, 2021
High level breaking changes:

* `@glimmer/integration-tests`, `@glimmer/manager`, `@glimmer/validator`
  * [#1330](glimmerjs/glimmer-vm#1330) Remove deprecated support for mutation after consumption during certain manager hooks ([@snewcomer](https://github.com/snewcomer))
* `@glimmer/manager`
  * [#1328](glimmerjs/glimmer-vm#1328) Remove deprecated Component Manager version 3.4 ([@nlfurniss](https://github.com/nlfurniss))
* `@glimmer/integration-tests`, `@glimmer/manager`
  * [#1329](glimmerjs/glimmer-vm#1329) Remove deprecated Modifier Manager version 3.13 ([@nlfurniss](https://github.com/nlfurniss))

See full details here:

https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.81.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants