Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8.0] Regression compiling to ES5 #17643

Closed
boris-petrov opened this issue Feb 19, 2019 · 2 comments
Closed

[3.8.0] Regression compiling to ES5 #17643

boris-petrov opened this issue Feb 19, 2019 · 2 comments

Comments

@boris-petrov
Copy link
Contributor

boris-petrov commented Feb 19, 2019

Not sure if this is the right title for this issue. Here is a reproduction.

Since updating to Ember 3.8.0, ember-ajax stops working in an ES5 build. isUnauthorizedError(new UnauthorizedError()) should return true (and does on ES6 builds on Ember 3.8 and any build on Ember 3.7-) but it returns false on ES5 on 3.8. isUnauthorizedError just does an instanceof check so the issue is somewhere deeper.

It's a regression from 3.7.3.

@Turbo87
Copy link
Member

Turbo87 commented Feb 28, 2019

this is most likely caused by #17216, since ember-ajax errors seem to extend EmberError 😞

@boris-petrov
Copy link
Contributor Author

This has been fixed in ember-ajax 5, thanks to @Turbo87!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants