Skip to content

Commit

Permalink
Merge pull request #19655 from mixonic/mixonic/remove-meta-destruction
Browse files Browse the repository at this point in the history
Remove meta-destruction-apis
  • Loading branch information
rwjblue committed Jul 21, 2021
2 parents d1fb1e7 + fb1d784 commit ff16032
Showing 1 changed file with 2 additions and 68 deletions.
70 changes: 2 additions & 68 deletions packages/@ember/-internals/meta/lib/meta.ts
@@ -1,6 +1,6 @@
import { symbol, toString } from '@ember/-internals/utils';
import { assert, deprecate } from '@ember/debug';
import { isDestroyed, isDestroying } from '@glimmer/destroyable';
import { assert } from '@ember/debug';
import { isDestroyed } from '@glimmer/destroyable';
import { DEBUG } from '@glimmer/env';
import { Revision, UpdatableTag } from '@glimmer/validator';

Expand Down Expand Up @@ -133,72 +133,6 @@ export class Meta {
return parent;
}

// These methods are here to prevent errors in legacy compat with some addons
// that used them as intimate API
setSourceDestroying() {
deprecate(
'setSourceDestroying is deprecated, use the destroy() API to destroy the object directly instead',
false,
{
id: 'meta-destruction-apis',
until: '3.25.0',
for: 'ember-source',
since: {
enabled: '3.21.0',
},
}
);
}

setSourceDestroyed() {
deprecate(
'setSourceDestroyed is deprecated, use the destroy() API to destroy the object directly instead',
false,
{
id: 'meta-destruction-apis',
until: '3.25.0',
for: 'ember-source',
since: {
enabled: '3.21.0',
},
}
);
}

isSourceDestroying() {
deprecate(
'isSourceDestroying is deprecated, use the isDestroying() API to check the object destruction state directly instead',
false,
{
id: 'meta-destruction-apis',
until: '3.25.0',
for: 'ember-source',
since: {
enabled: '3.21.0',
},
}
);

return isDestroying(this.source);
}

isSourceDestroyed() {
deprecate(
'isSourceDestroyed is deprecated, use the isDestroyed() API to check the object destruction state directly instead',
false,
{
id: 'meta-destruction-apis',
until: '3.25.0',
for: 'ember-source',
since: {
enabled: '3.21.0',
},
}
);

return isDestroyed(this.source);
}

setInitializing() {
this._isInit = true;
}
Expand Down

0 comments on commit ff16032

Please sign in to comment.