Proper fix without deleting tests -- thanks @chancancode!

emberjs · Mar 27, 2024 · f1f4fd7 · f1f4fd7
1 parent d328f73
commit f1f4fd7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/@ember/-internals/glimmer/tests/integration/components/curly-components-test.js b/packages/@ember/-internals/glimmer/tests/integration/components/curly-components-test.js
@@ -1269,7 +1269,7 @@ moduleFor(
 
     ['@test non-block with properties on this.attrs']() {
       this.registerComponent('non-block', {
-        template: 'In layout - someProp: {{this.attrs.someProp}}{{log this.attrs}}',
+        template: 'In layout - someProp: {{this.attrs.someProp}}',
       });
 
       this.render('{{non-block someProp=this.prop}}', {

diff --git a/packages/ember-template-compiler/lib/plugins/assert-against-attrs.ts b/packages/ember-template-compiler/lib/plugins/assert-against-attrs.ts
@@ -80,6 +80,18 @@ function isAttrs(node: AST.PathExpression, symbols: string[]) {
     return false;
   }
 
+  if (name === 'this' && node.head.type === 'ThisHead' && node.tail.includes('attrs')) {
+    // node.tail will be attrs.foo
+    // this makes it just foo (this.foo for the passed in node)
+    node.tail.shift();
+
+    // Deliberately do not say this is an "attrs" node.
+    // See this Deprecation RFC: https://github.com/emberjs/rfcs/pull/1016
+    // and this discussion here:
+    //   https://github.com/emberjs/ember.js/pull/20671
+    return false;
+  }
+
   if (name === 'attrs') {
     if (node.head.type === 'ThisHead') {
       node.tail.shift();