Expand smoke test coverage

This introduces scenario-tester (the setup we developed for the embroider repo) to the smoke tests and uses a matrix to test both classic and embroider builds.
emberjs · May 3, 2024 · eca9262 · eca9262
1 parent 896394f
commit eca9262
Show file tree

Hide file tree

Showing 10 changed files with 5,524 additions and 794 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -24,11 +24,18 @@ jobs:
   lint:
     name: Linting
     runs-on: ubuntu-latest
+     outputs:
+       matrix: ${{ steps.set-matrix.outputs.matrix }}
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/setup
       - name: linting
         run: pnpm lint
+      - id: set-matrix
+        working-directory: smoke-tests/scenarios
+        run: |
+          matrix_json=$(pnpm scenario-tester list --require @swc-node/register --files "*-test.ts" --matrix "pnpm run test --filter %s"   )
+          echo "matrix=$matrix_json" >> $GITHUB_OUTPUT        
 
   types:
     name: Type Checking (current version)
@@ -149,18 +156,18 @@ jobs:
     name: Smoke tests (Full Ember Apps)
     runs-on: ubuntu-latest
     needs: [basic-test, lint, types]
+    strategy:
+       fail-fast: false
+       matrix: ${{fromJson(needs.lint.outputs.matrix)}}
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/setup
       - name: build
         run: pnpm ember build -prod
       - name: test
-        # todo: potentially more apps? use matrix?
+        working-directory: smoke-tests/scenarios
         run: |
-          cd smoke-tests/ember-test-app/
-          pnpm install
-          pnpm link ../..
-          pnpm test
+          ${{ matrix.command }}
 
   node-test:
     name: Node.js Tests