Cleanup some types, don't use BlockStatement for scope tracking

emberjs · Mar 29, 2024 · de14c5f · de14c5f
1 parent 08b8c2b
commit de14c5f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/ember-template-compiler/lib/plugins/transform-wrap-mount-and-outlet.ts b/packages/ember-template-compiler/lib/plugins/transform-wrap-mount-and-outlet.ts
@@ -45,7 +45,6 @@ export default function transformWrapMountAndOutlet(env: EmberASTPluginEnvironme
     visitor: {
       Template: node,
       ElementNode: node,
-      BlockStatement: node,
       Block: node,
 
       MustacheStatement(node: AST.MustacheStatement): AST.Node | void {

diff --git a/packages/ember-template-compiler/lib/plugins/utils.ts b/packages/ember-template-compiler/lib/plugins/utils.ts
@@ -12,7 +12,7 @@ export function isStringLiteral(node: AST.Expression): node is AST.StringLiteral
   return node.type === 'StringLiteral';
 }
 
-function getLocalName(node: string | AST.Expression | AST.VarHead) {
+function getLocalName(node: string | AST.VarHead) {
   if (typeof node === 'string') return node;
 
   if (node.type === 'VarHead') {
@@ -28,7 +28,7 @@ export function trackLocals() {
   let locals = new Map();
 
   let node = {
-    enter(node: AST.Template | AST.Block | AST.ElementNode | AST.BlockStatement) {
+    enter(node: AST.Template | AST.Block | AST.ElementNode) {
       let params = 'params' in node ? node.params : node.blockParams;
       for (let param of params) {
         let name = getLocalName(param);
@@ -37,7 +37,7 @@ export function trackLocals() {
       }
     },
 
-    exit(node: AST.Template | AST.Block | AST.ElementNode | AST.BlockStatement) {
+    exit(node: AST.Template | AST.Block | AST.ElementNode) {
       let params = 'params' in node ? node.params : node.blockParams;
       for (let param of params) {
         let name = getLocalName(param);