Skip to content

Commit

Permalink
Remove jQuery usage from ember-testing
Browse files Browse the repository at this point in the history
As advised by feedback from core team, this removes all jQuery related testing helpers from ember-testing:
* `find`
* `findWithAssert`
* `triggerEvent`
* `keyEvent`
* `click`
* `fillIn`

All remaining helpers remain untouched for future official deprecation.
  • Loading branch information
simonihmig committed Aug 17, 2021
1 parent 860f334 commit cc749ef
Show file tree
Hide file tree
Showing 17 changed files with 5 additions and 2,371 deletions.
1 change: 0 additions & 1 deletion packages/ember-testing/index.js
Expand Up @@ -3,7 +3,6 @@ export { default as Adapter } from './lib/adapters/adapter';
export { default as setupForTesting } from './lib/setup_for_testing';
export { default as QUnitAdapter } from './lib/adapters/qunit';

import './lib/support'; // to handle various edge cases
import './lib/ext/application';
import './lib/ext/rsvp'; // setup RSVP + run loop integration
import './lib/helpers'; // adds helpers to helpers object in Test
Expand Down
135 changes: 0 additions & 135 deletions packages/ember-testing/lib/events.js

This file was deleted.

12 changes: 0 additions & 12 deletions packages/ember-testing/lib/helpers.js
@@ -1,29 +1,17 @@
import { registerHelper as helper, registerAsyncHelper as asyncHelper } from './test/helpers';
import andThen from './helpers/and_then';
import click from './helpers/click';
import currentPath from './helpers/current_path';
import currentRouteName from './helpers/current_route_name';
import currentURL from './helpers/current_url';
import fillIn from './helpers/fill_in';
import find from './helpers/find';
import findWithAssert from './helpers/find_with_assert';
import keyEvent from './helpers/key_event';
import { pauseTest, resumeTest } from './helpers/pause_test';
import triggerEvent from './helpers/trigger_event';
import visit from './helpers/visit';
import wait from './helpers/wait';

asyncHelper('visit', visit);
asyncHelper('click', click);
asyncHelper('keyEvent', keyEvent);
asyncHelper('fillIn', fillIn);
asyncHelper('wait', wait);
asyncHelper('andThen', andThen);
asyncHelper('pauseTest', pauseTest);
asyncHelper('triggerEvent', triggerEvent);

helper('find', find);
helper('findWithAssert', findWithAssert);
helper('currentRouteName', currentRouteName);
helper('currentPath', currentPath);
helper('currentURL', currentURL);
Expand Down
16 changes: 0 additions & 16 deletions packages/ember-testing/lib/helpers/-is-form-control.js

This file was deleted.

36 changes: 0 additions & 36 deletions packages/ember-testing/lib/helpers/click.js

This file was deleted.

46 changes: 0 additions & 46 deletions packages/ember-testing/lib/helpers/fill_in.js

This file was deleted.

41 changes: 0 additions & 41 deletions packages/ember-testing/lib/helpers/find.js

This file was deleted.

34 changes: 0 additions & 34 deletions packages/ember-testing/lib/helpers/find_with_assert.js

This file was deleted.

36 changes: 0 additions & 36 deletions packages/ember-testing/lib/helpers/key_event.js

This file was deleted.

0 comments on commit cc749ef

Please sign in to comment.