Skip to content

Commit

Permalink
Merge pull request #17128 from Turbo87/sourcemaps
Browse files Browse the repository at this point in the history
[BUGFIX lts] build: Turn off sourcemaps for TS-to-ES compilation
  • Loading branch information
rwjblue committed Oct 18, 2018
2 parents 8324f80 + 4ae81b7 commit cb12520
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@ jobs:
- TEST_SUITE=built-tests
- EMBER_ENV=production
- env: TEST_SUITE=old-jquery-and-extend-prototypes
- env: TEST_SUITE=node
- env:
- TEST_SUITE=node
- EMBER_ENV=production
node_js: "6"
- env: TEST_SUITE=blueprints
node_js: "6"
Expand Down
6 changes: 5 additions & 1 deletion broccoli/packages.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,11 @@ module.exports.getPackagesES = function getPackagesES() {
include: ['**/*.ts'],
});

let typescriptCompiled = typescript(debugTree(typescriptContents, `get-packages-es:ts:input`));
let typescriptCompiled = typescript(debugTree(typescriptContents, `get-packages-es:ts:input`), {
compilerOptions: {
sourceMap: false,
},
});

let debuggedCompiledTypescript = debugTree(typescriptCompiled, `get-packages-es:ts:output`);

Expand Down
27 changes: 27 additions & 0 deletions tests/node/sourcemap-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
var fs = require('fs');

QUnit.module('sourcemap validation', function() {
var assets = ['ember.debug', 'ember.prod', 'ember.min'];

assets.forEach(asset => {
QUnit.test(`${asset} has only a single sourcemaps comment`, function(assert) {
var jsPath = `dist/${asset}.js`;
assert.ok(fs.existsSync(jsPath));

var contents = fs.readFileSync(jsPath, 'utf-8');
var num = count(contents, '//# sourceMappingURL=');
assert.equal(num, 1);
});
});
});

function count(source, find) {
var num = 0;

var i = -1;
while ((i = source.indexOf(find, i + 1)) !== -1) {
num += 1;
}

return num;
}

0 comments on commit cb12520

Please sign in to comment.