Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #19660 from nlfurniss/remove-attrs
- Loading branch information
Showing
6 changed files
with
123 additions
and
141 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
packages/ember-template-compiler/tests/plugins/assert-against-attrs-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| import TransformTestCase from '../utils/transform-test-case'; | ||
| import { moduleFor, RenderingTestCase } from 'internal-test-helpers'; | ||
|
|
||
| moduleFor( | ||
| 'ember-template-compiler: assert against attrs', | ||
| class extends TransformTestCase { | ||
| ['@test it asserts against attrs']() { | ||
| expectAssertion(() => { | ||
| this.assertTransformed(`{{attrs.foo}}`, `{{attrs.foo}}`); | ||
| }, /Using {{attrs}} to reference named arguments is not supported. {{attrs.foo}} should be updated to {{@foo}}./); | ||
|
|
||
| expectAssertion(() => { | ||
| this.assertTransformed(`{{attrs.foo.bar}}`, `{{attrs.foo.bar}}`); | ||
| }, /Using {{attrs}} to reference named arguments is not supported. {{attrs.foo.bar}} should be updated to {{@foo.bar}}./); | ||
|
|
||
| expectAssertion(() => { | ||
| this.assertTransformed(`{{if attrs.foo "foo"}}`, `{{if attrs.foo "foo"}}`); | ||
| }, /Using {{attrs}} to reference named arguments is not supported. {{attrs.foo}} should be updated to {{@foo}}./); | ||
|
|
||
| expectAssertion(() => { | ||
| this.assertTransformed(`{{#if attrs.foo}}{{/if}}`, `{{#if attrs.foo}}{{/if}}`); | ||
| }, /Using {{attrs}} to reference named arguments is not supported. {{attrs.foo}} should be updated to {{@foo}}./); | ||
|
|
||
| expectAssertion(() => { | ||
| this.assertTransformed( | ||
| `{{deeply (nested attrs.foo.bar)}}`, | ||
| `{{deeply (nested attrs.foo.bar)}}` | ||
| ); | ||
| }, /Using {{attrs}} to reference named arguments is not supported. {{attrs.foo.bar}} should be updated to {{@foo.bar}}./); | ||
| } | ||
|
|
||
| ['@test it does not assert against this.attrs']() { | ||
| this.assertTransformed(`{{this.attrs.foo}}`, `{{this.attrs.foo}}`); | ||
| this.assertTransformed(`{{if this.attrs.foo "foo"}}`, `{{if this.attrs.foo "foo"}}`); | ||
| this.assertTransformed(`{{#if this.attrs.foo}}{{/if}}`, `{{#if this.attrs.foo}}{{/if}}`); | ||
| this.assertTransformed( | ||
| `{{deeply (nested this.attrs.foo.bar)}}`, | ||
| `{{deeply (nested this.attrs.foo.bar)}}` | ||
| ); | ||
| } | ||
| } | ||
| ); | ||
|
|
||
| moduleFor( | ||
| 'ember-template-compiler: not asserting against block params named "attrs"', | ||
| class extends RenderingTestCase { | ||
| ["@test it doesn't assert block params"]() { | ||
| this.registerComponent('foo', { | ||
| template: '{{#let "foo" as |attrs|}}{{attrs}}{{/let}}', | ||
| }); | ||
| this.render('<Foo />'); | ||
| this.assertComponentElement(this.firstChild, { content: 'foo' }); | ||
| } | ||
|
|
||
| ["@test it doesn't assert component block params"]() { | ||
| this.registerComponent('foo', { | ||
| template: '{{yield "foo"}}', | ||
| }); | ||
| this.render('<Foo as |attrs|>{{attrs}}</Foo>'); | ||
| this.assertComponentElement(this.firstChild, { content: 'foo' }); | ||
| } | ||
|
|
||
| ["@test it doesn't assert block params with nested keys"]() { | ||
| this.registerComponent('foo', { | ||
| template: '{{yield (hash bar="baz")}}', | ||
| }); | ||
| this.render('<Foo as |attrs|>{{attrs.bar}}</Foo>'); | ||
| this.assertComponentElement(this.firstChild, { content: 'baz' }); | ||
| } | ||
| } | ||
| ); |
62 changes: 0 additions & 62 deletions
62
packages/ember-template-compiler/tests/plugins/transform-attrs-into-args-test.js
This file was deleted.
Oops, something went wrong.