Skip to content

Commit

Permalink
Remove default implementation of getDebugInstance
Browse files Browse the repository at this point in the history
We have to make a judgement call per occurance to determine what we
should return here.

This whole mess could use some simplification, but we probably just
won't end up keeping this around for much longer once/if we remove
the action modifier, which is currently the only kind of modifier
we have internally (since `{{on}}` is implemented in glimmer-vm and
essentially duplicates this whole "internal" set up once more time
over there).
  • Loading branch information
chancancode committed Mar 29, 2024
1 parent 461aae5 commit a13c627
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions packages/@ember/-internals/glimmer/lib/modifiers/internal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class InternalModifierState implements Destroyable {
constructor(readonly instance: InternalModifier) {}
}

export class InternalModifierManager
export abstract class InternalModifierManager
implements ModifierManager<InternalModifierState, typeof InternalModifier>
{
constructor(private ModifierClass: typeof InternalModifier, private name: string) {}
Expand All @@ -78,9 +78,7 @@ export class InternalModifierManager
return null;
}

getDebugInstance(): unknown {
return null;
}
abstract getDebugInstance(state: InternalModifierState): unknown;

getDebugName(): string {
return this.name;
Expand Down

0 comments on commit a13c627

Please sign in to comment.