Merge pull request #16854 from emberjs/fix-factory-passing

[BUGFIX beta] Don't thread FactoryManager through createComponent
emberjs · Aug 2, 2018 · 9ea80e1 · 9ea80e1
2 parents 24ce7de + 26c91b2
commit 9ea80e1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/ember-glimmer/lib/component-managers/custom.ts b/packages/ember-glimmer/lib/component-managers/custom.ts
@@ -156,7 +156,7 @@ export default class CustomComponentManager<ComponentInstance>
     const capturedArgs = args.capture();
 
     let invocationArgs = valueForCapturedArgs(capturedArgs);
-    const component = delegate.createComponent(definition.ComponentClass, invocationArgs);
+    const component = delegate.createComponent(definition.ComponentClass.class, invocationArgs);
 
     return new CustomComponentState(delegate, component, capturedArgs);
   }

diff --git a/packages/ember-glimmer/tests/integration/custom-component-manager-test.js b/packages/ember-glimmer/tests/integration/custom-component-manager-test.js
@@ -130,9 +130,8 @@ if (GLIMMER_CUSTOM_COMPONENT_MANAGER) {
           EmberObject.extend({
             capabilities: capabilities('3.4'),
 
-            createComponent(factory, args) {
-              let Klass = factory.class;
-              return new Klass(args);
+            createComponent(Factory, args) {
+              return new Factory(args);
             },
 
             updateComponent() {},