Add deprecation warning to Ember.assign

emberjs · Aug 1, 2021 · 826daa7 · 826daa7
1 parent 015bd42
commit 826daa7
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/packages/@ember/deprecated-features/index.ts b/packages/@ember/deprecated-features/index.ts
@@ -8,3 +8,4 @@ export const JQUERY_INTEGRATION = !!'3.9.0';
 export const APP_CTRL_ROUTER_PROPS = !!'3.10.0-beta.1';
 export const MOUSE_ENTER_LEAVE_MOVE_EVENTS = !!'3.13.0-beta.1';
 export const PARTIALS = !!'3.15.0-beta.1';
+export const ASSIGN = !!'4.0.0';
diff --git a/packages/@ember/polyfills/lib/assign.ts b/packages/@ember/polyfills/lib/assign.ts
@@ -1,3 +1,5 @@
+import { deprecate } from '@ember/debug';
+
 /**
  @module @ember/polyfills
 */
@@ -28,6 +30,20 @@ export function assign(target: object, ...sources: any[]): any;
   @static
 */
 export function assign(target: object) {
+  deprecate(
+    'Use of `assign` has been deprecated. Please use `Object.assign` or the spread operator instead.',
+    false,
+    {
+      id: 'ember-polyfills.deprecate-assign',
+      until: '5.0.0',
+      url: 'https://deprecations.emberjs.com/v4.x/#toc_ember-polyfills-deprecate-assign',
+      for: 'ember-source',
+      since: {
+        enabled: '4.0.0',
+      },
+    }
+  );
+
   for (let i = 1; i < arguments.length; i++) {
     let arg = arguments[i];
     if (!arg) {

diff --git a/packages/@ember/polyfills/tests/assign_test.js b/packages/@ember/polyfills/tests/assign_test.js
@@ -49,7 +49,9 @@ moduleFor(
   'Ember.assign (polyfill)',
   class extends AssignTests {
     assign() {
-      return assignPolyfill(...arguments);
+      return expectDeprecation(() => {
+        assignPolyfill(...arguments);
+      }, 'Use of `assign` has been deprecated. Please use `Object.assign` or the spread operator instead.');
     }
   }
 );