Merge pull request #19541 from emberjs/fix-3-27-deprecations

[BUGFIX release] 3.27 deprecation metadata
emberjs · May 12, 2021 · 2f6a72e · 2f6a72e
2 parents 5d2f742 + 566af49
commit 2f6a72e
Show file tree

Hide file tree

Showing 35 changed files with 197 additions and 77 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -281,7 +281,7 @@ module.exports = {
 
     if (targets.includes('ie 11')) {
       this.ui.writeWarnLine(
-        'Internet Explorer 11 is listed in your compilation targets, but it will no longer be supported in the next major version of Ember. Please update your targets to remove IE 11 and include new targets that are within the updated support policy. For details on the new browser support policy, see:\n\n - The official documentation: http://emberjs.com/browser-support\n - the deprecation guide: https://emberjs.com/deprecations/v3.x#toc_3-0-browser-support-policy\n'
+        'Internet Explorer 11 is listed in your compilation targets, but it will no longer be supported in the next major version of Ember. Please update your targets to remove IE 11 and include new targets that are within the updated support policy. For details on the new browser support policy, see:\n\n - The official documentation: http://emberjs.com/browser-support\n - the deprecation guide: https://deprecations.emberjs.com/v3.x#toc_3-0-browser-support-policy\n'
       );
     }
 

diff --git a/packages/@ember/-internals/console/index.js b/packages/@ember/-internals/console/index.js
@@ -6,7 +6,7 @@ import { LOGGER } from '@ember/deprecated-features';
 const DEPRECATION_MESSAGE = 'Use of Ember.Logger is deprecated. Please use `console` for logging.';
 const DEPRECATION_ID = 'ember-console.deprecate-logger';
 const DEPRECATION_URL =
-  'https://emberjs.com/deprecations/v3.x#toc_use-console-rather-than-ember-logger';
+  'https://deprecations.emberjs.com/v3.x#toc_use-console-rather-than-ember-logger';
 /**
    @module ember
 */

diff --git a/packages/@ember/-internals/glimmer/lib/component.ts b/packages/@ember/-internals/glimmer/lib/component.ts
@@ -687,7 +687,7 @@ const Component = CoreView.extend(
         {
           id: 'ember-views.event-dispatcher.mouseenter-leave-move',
           until: '4.0.0',
-          url: 'https://emberjs.com/deprecations/v3.x#toc_component-mouseenter-leave-move',
+          url: 'https://deprecations.emberjs.com/v3.x#toc_component-mouseenter-leave-move',
           for: 'ember-source',
           since: {
             enabled: '3.13.0-beta.1',
@@ -700,7 +700,7 @@ const Component = CoreView.extend(
         {
           id: 'ember-views.event-dispatcher.mouseenter-leave-move',
           until: '4.0.0',
-          url: 'https://emberjs.com/deprecations/v3.x#toc_component-mouseenter-leave-move',
+          url: 'https://deprecations.emberjs.com/v3.x#toc_component-mouseenter-leave-move',
           for: 'ember-source',
           since: {
             enabled: '3.13.0-beta.1',
@@ -713,7 +713,7 @@ const Component = CoreView.extend(
         {
           id: 'ember-views.event-dispatcher.mouseenter-leave-move',
           until: '4.0.0',
-          url: 'https://emberjs.com/deprecations/v3.x#toc_component-mouseenter-leave-move',
+          url: 'https://deprecations.emberjs.com/v3.x#toc_component-mouseenter-leave-move',
           for: 'ember-source',
           since: {
             enabled: '3.13.0-beta.1',

diff --git a/packages/@ember/-internals/glimmer/lib/components/-link-to.ts b/packages/@ember/-internals/glimmer/lib/components/-link-to.ts
@@ -1035,8 +1035,11 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
           {
             id: 'ember.built-in-components.reopen',
             for: 'ember-source',
-            since: {},
+            since: {
+              enabled: '3.27.0',
+            },
             until: '4.0.0',
+            url: 'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-reopen',
           }
         );
 
@@ -1060,8 +1063,11 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
           {
             id: 'ember.built-in-components.reopen',
             for: 'ember-source',
-            since: {},
+            since: {
+              enabled: '3.27.0',
+            },
             until: '4.0.0',
+            url: 'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-reopen',
           }
         );
 

diff --git a/packages/@ember/-internals/glimmer/lib/components/-textarea.ts b/packages/@ember/-internals/glimmer/lib/components/-textarea.ts
@@ -62,8 +62,11 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
           {
             id: 'ember.built-in-components.reopen',
             for: 'ember-source',
-            since: {},
+            since: {
+              enabled: '3.27.0',
+            },
             until: '4.0.0',
+            url: 'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-reopen',
           }
         );
 
@@ -87,8 +90,11 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
           {
             id: 'ember.built-in-components.reopen',
             for: 'ember-source',
-            since: {},
+            since: {
+              enabled: '3.27.0',
+            },
             until: '4.0.0',
+            url: 'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-reopen',
           }
         );
 

diff --git a/packages/@ember/-internals/glimmer/lib/components/abstract-input.ts b/packages/@ember/-internals/glimmer/lib/components/abstract-input.ts
@@ -239,7 +239,7 @@ export function handleDeprecatedFeatures(
               for: 'ember-source',
               since: {},
               until: '4.0.0',
-              url: 'https://emberjs.com/deprecations/v3.x#toc_ember-component-send-action',
+              url: 'https://deprecations.emberjs.com/v3.x#toc_ember-component-send-action',
             }
           );
 
@@ -270,7 +270,7 @@ export function handleDeprecatedFeatures(
                 for: 'ember-source',
                 since: {},
                 until: '4.0.0',
-                url: 'https://emberjs.com/deprecations/v3.x#toc_ember-component-send-action',
+                url: 'https://deprecations.emberjs.com/v3.x#toc_ember-component-send-action',
               }
             );
 

diff --git a/packages/@ember/-internals/glimmer/lib/components/checkbox.ts b/packages/@ember/-internals/glimmer/lib/components/checkbox.ts
@@ -181,8 +181,11 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
           {
             id: 'ember.built-in-components.reopen',
             for: 'ember-source',
-            since: {},
+            since: {
+              enabled: '3.27.0',
+            },
             until: '4.0.0',
+            url: 'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-reopen',
           }
         );
 
@@ -206,8 +209,11 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
           {
             id: 'ember.built-in-components.reopen',
             for: 'ember-source',
-            since: {},
+            since: {
+              enabled: '3.27.0',
+            },
             until: '4.0.0',
+            url: 'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-reopen',
           }
         );
 

diff --git a/packages/@ember/-internals/glimmer/lib/components/internal.ts b/packages/@ember/-internals/glimmer/lib/components/internal.ts
@@ -274,8 +274,12 @@ export function handleDeprecatedArguments(target: DeprecatingInternalComponentCo
         deprecate(`Passing the \`@${name}\` argument to <${angle}> is deprecated.`, false, {
           id: 'ember.built-in-components.legacy-arguments',
           for: 'ember-source',
-          since: {},
+          since: {
+            enabled: '3.27.0',
+          },
           until: '4.0.0',
+          url:
+            'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-arguments',
         });
 
         this.modernized = false;
@@ -356,8 +360,12 @@ export function handleDeprecatedAttributeArguments(
               {
                 id: 'ember.built-in-components.legacy-attribute-arguments',
                 for: 'ember-source',
-                since: {},
+                since: {
+                  enabled: '3.27.0',
+                },
                 until: '4.0.0',
+                url:
+                  'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-attribute-arguments',
               }
             );
 
@@ -517,8 +525,12 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
             {
               id: 'ember.built-in-components.legacy-attribute-arguments',
               for: 'ember-source',
-              since: {},
+              since: {
+                enabled: '3.27.0',
+              },
               until: '4.0.0',
+              url:
+                'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-attribute-arguments',
             }
           );
 
@@ -530,8 +542,12 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
             {
               id: 'ember.built-in-components.legacy-attribute-arguments',
               for: 'ember-source',
-              since: {},
+              since: {
+                enabled: '3.27.0',
+              },
               until: '4.0.0',
+              url:
+                'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-attribute-arguments',
             }
           );
 

diff --git a/packages/@ember/-internals/glimmer/lib/components/link-to.ts b/packages/@ember/-internals/glimmer/lib/components/link-to.ts
@@ -393,7 +393,6 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
     ['role', 'ariaRole'],
 
     // LinkTo
-    'href',
     'title',
     'rel',
     'tabindex',
@@ -402,6 +401,23 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
 
   handleDeprecatedEventArguments(LinkTo);
 
+  // @href
+  {
+    let superOnUnsupportedArgument = prototype['onUnsupportedArgument'];
+
+    Object.defineProperty(prototype, 'onUnsupportedArgument', {
+      configurable: true,
+      enumerable: false,
+      value: function onUnsupportedArgument(this: LinkTo, name: string): void {
+        if (name === 'href') {
+          assert(`Passing the \`@href\` argument to <LinkTo> is not supported.`);
+        } else {
+          superOnUnsupportedArgument.call(this, name);
+        }
+      },
+    });
+  }
+
   // @tagName
   {
     let superOnUnsupportedArgument = prototype['onUnsupportedArgument'];
@@ -454,8 +470,12 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
               {
                 id: 'ember.built-in-components.legacy-arguments',
                 for: 'ember-source',
-                since: {},
+                since: {
+                  enabled: '3.27.0',
+                },
                 until: '4.0.0',
+                url:
+                  'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-arguments',
               }
             );
 
@@ -472,8 +492,12 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
               {
                 id: 'ember.built-in-components.legacy-arguments',
                 for: 'ember-source',
-                since: {},
+                since: {
+                  enabled: '3.27.0',
+                },
                 until: '4.0.0',
+                url:
+                  'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-arguments',
               }
             );
 
@@ -505,8 +529,12 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
               {
                 id: 'ember.built-in-components.legacy-arguments',
                 for: 'ember-source',
-                since: {},
+                since: {
+                  enabled: '3.27.0',
+                },
                 until: '4.0.0',
+                url:
+                  'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-arguments',
               }
             );
           } else {
@@ -519,8 +547,12 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
               {
                 id: 'ember.built-in-components.legacy-arguments',
                 for: 'ember-source',
-                since: {},
+                since: {
+                  enabled: '3.27.0',
+                },
                 until: '4.0.0',
+                url:
+                  'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-arguments',
               }
             );
 
@@ -540,8 +572,12 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
               {
                 id: 'ember.built-in-components.legacy-arguments',
                 for: 'ember-source',
-                since: {},
+                since: {
+                  enabled: '3.27.0',
+                },
                 until: '4.0.0',
+                url:
+                  'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-arguments',
               }
             );
 
@@ -556,8 +592,12 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
               {
                 id: 'ember.built-in-components.legacy-arguments',
                 for: 'ember-source',
-                since: {},
+                since: {
+                  enabled: '3.27.0',
+                },
                 until: '4.0.0',
+                url:
+                  'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-arguments',
               }
             );
           }

diff --git a/packages/@ember/-internals/glimmer/lib/components/text-field.ts b/packages/@ember/-internals/glimmer/lib/components/text-field.ts
@@ -225,8 +225,11 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
           {
             id: 'ember.built-in-components.reopen',
             for: 'ember-source',
-            since: {},
+            since: {
+              enabled: '3.27.0',
+            },
             until: '4.0.0',
+            url: 'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-reopen',
           }
         );
 
@@ -250,8 +253,11 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
           {
             id: 'ember.built-in-components.reopen',
             for: 'ember-source',
-            since: {},
+            since: {
+              enabled: '3.27.0',
+            },
             until: '4.0.0',
+            url: 'https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-reopen',
           }
         );
 

diff --git a/packages/@ember/-internals/glimmer/lib/environment.ts b/packages/@ember/-internals/glimmer/lib/environment.ts
@@ -118,6 +118,7 @@ const VM_DEPRECATION_OVERRIDES: (DeprecationOptions & {
   },
   {
     id: 'argument-less-helper-paren-less-invocation',
+    url: 'https://deprecations.emberjs.com/v3.x#toc_argument-less-helper-paren-less-invocation',
     until: '4.0.0',
     for: 'ember-source',
     since: {

diff --git a/packages/@ember/-internals/glimmer/lib/modifiers/action.ts b/packages/@ember/-internals/glimmer/lib/modifiers/action.ts
@@ -223,7 +223,7 @@ class ActionModifierManager implements InternalModifierManager<ActionState, obje
       {
         id: 'ember-views.event-dispatcher.mouseenter-leave-move',
         until: '4.0.0',
-        url: 'https://emberjs.com/deprecations/v3.x#toc_action-mouseenter-leave-move',
+        url: 'https://deprecations.emberjs.com/v3.x#toc_action-mouseenter-leave-move',
         for: 'ember-source',
         since: {
           enabled: '3.13.0-beta.1',

diff --git a/packages/@ember/-internals/glimmer/lib/utils/managers.ts b/packages/@ember/-internals/glimmer/lib/utils/managers.ts
@@ -22,7 +22,7 @@ export function setComponentManager(
       {
         id: 'deprecate-string-based-component-manager',
         until: '4.0.0',
-        url: 'https://emberjs.com/deprecations/v3.x/#toc_component-manager-string-lookup',
+        url: 'https://deprecations.emberjs.com/v3.x/#toc_component-manager-string-lookup',
         for: 'ember-source',
         since: {
           enabled: '3.8.0',
@@ -49,7 +49,7 @@ if (DEBUG) {
       version === '3.13',
       {
         id: 'manager-capabilities.components-3-4',
-        url: 'https://emberjs.com/deprecations/v3.x#toc_manager-capabilities-components-3-4',
+        url: 'https://deprecations.emberjs.com/v3.x#toc_manager-capabilities-components-3-4',
         until: '4.0.0',
         for: 'ember-source',
         since: {
@@ -67,7 +67,7 @@ if (DEBUG) {
       version === '3.22',
       {
         id: 'manager-capabilities.modifiers-3-13',
-        url: 'https://emberjs.com/deprecations/v3.x#toc_manager-capabilities-modifiers-3-13',
+        url: 'https://deprecations.emberjs.com/v3.x#toc_manager-capabilities-modifiers-3-13',
         until: '4.0.0',
         for: 'ember-source',
         since: {