Merge pull request #19477 from hmajoros/hmajoros/LinkToFix

emberjs · Mar 29, 2021 · 20aacf5 · 20aacf5
2 parents 4b1288c + 62e7b92
commit 20aacf5
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 6 deletions.
diff --git a/packages/@ember/-internals/glimmer/lib/components/-link-to.ts b/packages/@ember/-internals/glimmer/lib/components/-link-to.ts
@@ -499,12 +499,7 @@ const LinkComponent = EmberComponent.extend({
   init() {
     this._super(...arguments);
 
-    assert(
-      'You attempted to use the <LinkTo> component within a routeless engine, this is not supported. ' +
-        'If you are using the ember-engines addon, use the <LinkToExternal> component instead. ' +
-        'See https://ember-engines.com/docs/links for more info.',
-      !this._isEngine || this._engineMountPoint !== undefined
-    );
+    this.assertLinkToOrigin();
 
     // Map desired event name to invoke function
     let { eventName } = this;
@@ -636,6 +631,23 @@ const LinkComponent = EmberComponent.extend({
     }
   ),
 
+  /**
+   * Method to assert that LinkTo is not used inside of a routeless engine. This method is
+   * overridden in ember-engines link-to-external component to just be a noop, since the
+   * link-to-external component extends the link-to component.
+   *
+   * @method assertLinkToOrigin
+   * @private
+   */
+  assertLinkToOrigin() {
+    assert(
+      'You attempted to use the <LinkTo> component within a routeless engine, this is not supported. ' +
+        'If you are using the ember-engines addon, use the <LinkToExternal> component instead. ' +
+        'See https://ember-engines.com/docs/links for more info.',
+      !this._isEngine || this._engineMountPoint !== undefined
+    );
+  },
+
   _isActive(routerState: RouterState): boolean {
     if (this.loading) {
       return false;

diff --git a/tests/docs/expected.js b/tests/docs/expected.js
@@ -92,6 +92,7 @@ module.exports = {
     'arrayContentWillChange',
     'assert',
     'assertDestroyablesDestroyed',
+    'assertLinkToOrigin',
     'assign',
     'associateDestroyableChild',
     'asyncEnd',