Merge pull request #19806 from mixonic/mixonic/drop-export-of-built-ins

emberjs · Nov 10, 2021 · 032bdc4 · 032bdc4
2 parents 4eb36b9 + 5d24ae7
commit 032bdc4
Show file tree

Hide file tree

Showing 57 changed files with 564 additions and 7,891 deletions.
diff --git a/packages/@ember/-internals/glimmer/index.ts b/packages/@ember/-internals/glimmer/index.ts
@@ -295,11 +295,8 @@
 export { templateFactory as template, templateCacheCounters } from '@glimmer/opcode-compiler';
 
 export { default as RootTemplate } from './lib/templates/root';
-export { default as Checkbox } from './lib/components/checkbox';
-export { default as TextField } from './lib/components/text-field';
-export { default as TextArea } from './lib/components/-textarea';
-export { default as LinkComponent } from './lib/components/-link-to';
 export { default as Input } from './lib/components/input';
+export { default as LinkTo } from './lib/components/link-to';
 export { default as Textarea } from './lib/components/textarea';
 export { default as Component } from './lib/component';
 export { default as Helper, helper } from './lib/helper';

diff --git a/packages/@ember/-internals/glimmer/lib/component.ts b/packages/@ember/-internals/glimmer/lib/component.ts
@@ -1,6 +1,6 @@
 import { get, PROPERTY_DID_CHANGE } from '@ember/-internals/metal';
 import { getOwner } from '@ember/-internals/owner';
-import { CoreObject, TargetActionSupport } from '@ember/-internals/runtime';
+import { TargetActionSupport } from '@ember/-internals/runtime';
 import {
   ActionSupport,
   ChildViewsSupport,
@@ -11,8 +11,7 @@ import {
   ViewMixin,
   ViewStateSupport,
 } from '@ember/-internals/views';
-import { EMBER_MODERNIZED_BUILT_IN_COMPONENTS } from '@ember/canary-features';
-import { assert, deprecate } from '@ember/debug';
+import { assert } from '@ember/debug';
 import { DEBUG } from '@glimmer/env';
 import { Environment } from '@glimmer/interfaces';
 import { setInternalComponentManager } from '@glimmer/manager';
@@ -1044,71 +1043,4 @@ Component.reopenClass({
 
 setInternalComponentManager(CURLY_COMPONENT_MANAGER, Component);
 
-if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
-  Object.defineProperty(Component, '_wasReopened', {
-    configurable: true,
-    enumerable: false,
-    writable: true,
-    value: false,
-  });
-
-  Object.defineProperty(Component, 'reopen', {
-    configurable: true,
-    enumerable: false,
-    writable: true,
-    value: function reopen(this: typeof Component, ...args: unknown[]): unknown {
-      if (this === Component) {
-        deprecate(
-          'Reopening the Ember.Component super class itself is deprecated. ' +
-            'Consider alternatives such as installing event listeners on ' +
-            'the document or add the customizations to specific subclasses.',
-          false,
-          {
-            id: 'ember.component.reopen',
-            for: 'ember-source',
-            since: {
-              enabled: '3.27.0',
-            },
-            url: 'https://deprecations.emberjs.com/v3.x#toc_ember-component-reopen',
-            until: '4.0.0',
-          }
-        );
-
-        Component._wasReopened = true;
-      }
-
-      return CoreObject.reopen.call(this, ...args);
-    },
-  });
-
-  Object.defineProperty(Component, 'reopenClass', {
-    configurable: true,
-    enumerable: false,
-    writable: true,
-    value: function reopenClass(this: typeof Component, ...args: unknown[]): unknown {
-      if (this === Component) {
-        deprecate(
-          'Reopening the Ember.Component super class itself is deprecated. ' +
-            'Consider alternatives such as installing event listeners on ' +
-            'the document or add the customizations to specific subclasses.',
-          false,
-          {
-            id: 'ember.component.reopen',
-            for: 'ember-source',
-            url: 'https://deprecations.emberjs.com/v3.x#toc_ember-component-reopen',
-            since: {
-              enabled: '3.27.0',
-            },
-            until: '4.0.0',
-          }
-        );
-
-        Component._wasReopened = true;
-      }
-
-      return CoreObject.reopenClass.call(this, ...args);
-    },
-  });
-}
-
 export default Component;