Merge pull request #16784 from rwjblue/moar-array-proxy-tweaks

[BUGFIX] Setting ArrayProxy#content in willDestroy resets length.
emberjs · Jun 28, 2018 · 01f5b90 · 01f5b90
2 parents c714f6e + 7189bf0
commit 01f5b90
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 5 deletions.
diff --git a/packages/ember-runtime/lib/system/array_proxy.js b/packages/ember-runtime/lib/system/array_proxy.js
@@ -210,9 +210,7 @@ export default class ArrayProxy extends EmberObject {
     if (content) {
       replace(content, value, removedCount, added);
 
-      this._lengthDirty = true;
-      this._objectsDirtyIndex = 0;
-      this._objects = null;
+      this._invalidate();
     }
   }
 
@@ -225,11 +223,12 @@ export default class ArrayProxy extends EmberObject {
       this._removeArrangedContentArrayObsever();
       this.arrayContentWillChange(0, oldLength, newLength);
 
-      this._objectsDirtyIndex = 0;
-      this._lengthDirty = true;
+      this._invalidate();
 
       this.arrayContentDidChange(0, oldLength, newLength);
       this._addArrangedContentArrayObsever();
+    } else if (key === 'content') {
+      this._invalidate();
     }
   }
 
@@ -277,6 +276,11 @@ export default class ArrayProxy extends EmberObject {
 
     this.arrayContentDidChange(idx, removedCnt, addedCnt);
   }
+
+  _invalidate() {
+    this._objectsDirtyIndex = 0;
+    this._lengthDirty = true;
+  }
 }
 
 ArrayProxy.reopen(MutableArray, {

diff --git a/packages/ember-runtime/tests/system/array_proxy/length_test.js b/packages/ember-runtime/tests/system/array_proxy/length_test.js
@@ -78,6 +78,24 @@ moduleFor(
       assert.deepEqual(obj.content, null, 'content was updated');
     }
 
+    '@test accessing length after content set to null in willDestroy'(assert) {
+      let obj = ArrayProxy.extend({
+        willDestroy() {
+          this.set('content', null);
+          this._super(...arguments);
+        },
+      }).create({
+        content: ['foo', 'bar'],
+      });
+
+      assert.equal(obj.length, 2, 'precond');
+
+      this.runTask(() => obj.destroy());
+
+      assert.equal(obj.length, 0, 'length is 0 without content');
+      assert.deepEqual(obj.content, null, 'content was updated');
+    }
+
     '@test setting length to 0'(assert) {
       let obj = ArrayProxy.create({ content: ['foo', 'bar'] });