Feature - adds setupOnerror function to allow patching Ember.onerror in tests #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Jan 25, 2019
scalvert
changed the title
scalvert
changed the title
rwjblue
reviewed
Jan 25, 2019
scalvert
force-pushed
the
setup-ember-onerror
branch
from
e133b7f
to
21f11ec
Compare
rwjblue
approved these changes
Jan 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's fairly common to want to temporarily set an
Ember.onerrorhandler to test specific aspects of error handling within your application. Newer versions of sinon do not make this easy, as theEmber.onerrorobject is a defined property, and sinon has a codepath that excludes stubbing this particular method (it's a bit weird to stub it anyway, isn't it?).This PR introduces a utility to setup
Ember.onerror, and ensures that it's reset to its original state when the test context is torn down.TODO: