Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize params for calling triggerEvent on file input #428

Merged
merged 2 commits into from Oct 16, 2018
Merged

Standardize params for calling triggerEvent on file input #428

merged 2 commits into from Oct 16, 2018

Conversation

mattdonnelly
Copy link
Contributor

@mattdonnelly mattdonnelly commented Oct 15, 2018 •
edited by rwjblue

Why?

Following on from the feedback in this PR: #399

How?

I've updated triggerEvent method to accept an options param as an object containing a key files and issue a deprecation warning when passed an array

Closes #399

@rwjblue rwjblue merged commit fb75db0 into emberjs:master Oct 16, 2018
@mattdonnelly mattdonnelly deleted the mattd/standardize-file-input-options branch October 16, 2018 13:47
@andreyfel andreyfel mentioned this pull request Oct 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattdonnelly @rwjblue