Update Dependencies #409
Update Dependencies #409
Conversation
wagenet
force-pushed
the
update-dependencies
branch
from
2f44a07
to
ba8162a
Compare
|
Turns out that almost all the dependencies I upgraded depend on Node 6, so not sure if it makes sense to fix this PR. @rwjblue |
wagenet
force-pushed
the
update-dependencies
branch
from
ba8162a
to
2864afc
Compare
|
@wagenet - Looks like we only have a |
wagenet
force-pushed
the
update-dependencies
branch
from
40eb7d7
to
8d35312
Compare
|
See #457 for some context on the failing tests. |
wagenet
force-pushed
the
update-dependencies
branch
2 times, most recently
from
c2f8dda
to
f387355
Compare
|
@rwjblue so we're still blocked here because of the issue with |
|
Lets skip that one test for now, then follow up on the |
wagenet
force-pushed
the
update-dependencies
branch
2 times, most recently
from
77f557d
to
fceccdf
Compare
|
Hmm... seeing a few of the scenarios failing. Will have to investigate further next week. |
wagenet
force-pushed
the
update-dependencies
branch
from
fceccdf
to
d43a85a
Compare
|
@rwjblue finally passing! |
config/ember-try.js
Outdated
| return { | ||
| useYarn: true, | ||
| scenarios: [ | ||
| { | ||
| name: 'ember-2.0', | ||
| env, |
There was a problem hiding this comment.
We cannot use the shared env here (Ember 2.0 doesn't support use without jQuery), maybe make a envWithJQuery and an envWithoutJQuery?
There was a problem hiding this comment.
Hmm... well we can use it, it just doesn't do anything meaningful, so I agree that it is confusing.
There was a problem hiding this comment.
Which scenarios are actually expected to have jQuery?
There was a problem hiding this comment.
2.16 and higher should be tested without jquery, we should also add entries in Travis.yml and try config for 2.18 and 3.4
|
Some conflicts now also (sorry for the delays / run around here)... |
wagenet
force-pushed
the
update-dependencies
branch
from
d43a85a
to
2f3218f
Compare
No description provided.