WIP: Convert to TypeScript #994
Conversation
| @@ -45,6 +45,35 @@ module.exports = { | |||
| extends: ['plugin:node/recommended'], | |||
| }, | |||
|
|
|||
| // ts files | |||
| { | |||
There was a problem hiding this comment.
Can remove this if you don't like UBER-STRICTNESS, but I find it useful during conversion at least
| "addon-test-support/**/*" | ||
| ], | ||
|
|
||
| // type checking |
| @@ -0,0 +1,17 @@ | |||
| declare module 'ember-cli-test-loader/test-support/index' { | |||
There was a problem hiding this comment.
Should we port these to the library in question? Yaks on yaks on yaks.
There was a problem hiding this comment.
Can either merge this as is or release ember-cli/ember-cli-test-loader#77 and switch to using that.
gitKrystan
force-pushed
the
ts
branch
3 times, most recently
from
aa6f61c
to
d04fbeb
Compare
| @@ -15,6 +15,8 @@ | |||
| !.* | |||
| .*/ | |||
| .eslintcache | |||
| /.yalc* | |||
| /yalc.lock | |||
There was a problem hiding this comment.
Can revert once emberjs/ember-test-helpers#1319 is released
| @@ -20,6 +20,9 @@ | |||
| /npm-debug.log* | |||
| /testem.log | |||
| /yarn-error.log | |||
| /.yalc* | |||
| /yalc.lock | |||
There was a problem hiding this comment.
Can revert once emberjs/ember-test-helpers#1319 is released
| @@ -15,6 +15,8 @@ | |||
| !.* | |||
| .eslintcache | |||
| .lint-todo/ | |||
| /.yalc* | |||
| /yalc.lock | |||
There was a problem hiding this comment.
Can revert once emberjs/ember-test-helpers#1319 is released
package.json
Outdated
| @@ -49,12 +52,14 @@ | |||
| "@babel/core": "^7.20.5", | |||
| "@babel/eslint-parser": "^7.19.1", | |||
| "@ember/optional-features": "^2.0.0", | |||
| "@ember/test-helpers": "^2.9.3", | |||
| "@ember/test-helpers": "file:.yalc/@ember/test-helpers", | |||
There was a problem hiding this comment.
FIXME once emberjs/ember-test-helpers#1319 is released
| @@ -0,0 +1,37 @@ | |||
| { | |||
There was a problem hiding this comment.
Review closely bc I've been known to muck these things up :-P
Consuming packages were looking at the TS files instead of the .d.ts files
| @@ -88,7 +93,7 @@ | |||
| "qunit": "^2.13.0" | |||
| }, | |||
| "engines": { | |||
| "node": "14.* || 16.* || >= 18" | |||
| "node": "16.* || >= 18" | |||
There was a problem hiding this comment.
Needed for latest @ember/test-helpers
A better fix for #957
Requires:
ember-cli/ember-cli-test-loader#77 (optional)
emberjs/ember-test-helpers#1319 (merged, NEEDS RELEASE)
@types/qunit changes: DefinitelyTyped/DefinitelyTyped#63805 (DONE: merged, released)
#1017 (DONE: merged)