Update ember-auto-import to 2.x #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/ember-auto-import-v2-node-12
branch
2 times, most recently
from
2097df8
to
4ef3a48
Compare
This was referenced Mar 14, 2022
mydea
force-pushed
the
fn/ember-auto-import-v2-node-12
branch
from
4ef3a48
to
d38bb7e
Compare
|
Let's do a dedicated PR to drop support for Node < 14 (the engines field should be |
|
@mydea hi! do you have some time to resolve the conflicts? |
mydea
changed the title
mydea
force-pushed
the
fn/ember-auto-import-v2-node-12
branch
from
d38bb7e
to
3806e10
Compare
|
I have rebased this on master (and removed all references to dropping any node version from this PR)! |
|
Thank you for the quick turnaround! |
This was referenced Jul 25, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates ember-auto-import to 2.x (ember-qunit is the last addon in our app still being tied to v1).