Make sure focus related tests don't fail when the test container is hidden #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
commented
Dec 9, 2021
| } | ||
|
|
||
| testContainer.style.visibility = containerVisibility; | ||
| if (params.nocontainer) { | ||
| testContainer.classList.add('ember-testing-container-hidden'); |
There was a problem hiding this comment.
First simply used a hidden class, but that is such a commonly used utility class that I switched to using ember-testing-container-hidden to avoid conflicts. I renamed the full-screen class to ember-testing-container-full-screen for the same reason and consistency.
bertdeblock
force-pushed
the
make-sure-focus-related-test-dont-fail-when-the-container-is-hidden
branch
from
b80d4da
to
ed643e1
Compare
rwjblue
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that rely on an element being focussed (when using e.g. ember-focus-trap) fail when the test container is hidden using e.g.
display: none;orvisibility: hidden.Switching to an
opacity: 0; pointer-events: none;approach fixes this.