Add fullscreencontainer query param (similar to devmode but does not modify test timeout)
#763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitpaulk
force-pushed
the
add-fullscreencontainer
branch
from
18390dc
to
e114a31
Compare
|
Not sure if there's a good way to write tests for this, I don't see any tests for |
rwjblue
approved these changes
Nov 3, 2020
rwjblue
changed the title
fullscreencontainer query param (similar to devmode but does not modify test timeout)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #595 (comment), this adds a
fullscreencontainerquery param that does exactly whatdevmodedoes, minus removing the test timeout.This is useful for tests that depend on exact dimensions of elements (like scrolling an element to a certain position). An example: #521