Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exception method from QUnit test adapter. #307

Merged
merged 1 commit into from Jan 17, 2018

Commits on Dec 18, 2017

  1. Remove exception method from QUnit test adapter.

    As of Ember 2.17 the `Ember.Test.adapter` is not required to have an
    `exception` method, and the method essentially has no purpose. The
    default implementation (in the `Ember.Test.QUnitAdapter`) is to
    re-throw, but that is _exactly_ what happens by default.
    
    This removes "yet another magical testing thing", and relies on both
    Ember and QUnit's default behaviors to ensure that tests properly fail
    when unhandled RSVP rejections occur.
    rwjblue committed Dec 18, 2017
    Copy the full SHA
    d651517 View commit details
    Browse the repository at this point in the history