Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce theme config and add qunit-theme-ember as option #1166

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+52 −3
Open

feat: introduce theme config and add qunit-theme-ember as option #1166

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
28918e9
deps: install qunit-theme-ember
IgnaceMaes Dec 9, 2023
f4a840d
feat: import qunit-theme-ember css
IgnaceMaes Dec 9, 2023
851304f
fix: import qunit-theme after container styles
IgnaceMaes Dec 9, 2023
c193c1e
fix: use importSync to ensure order of css
IgnaceMaes Dec 9, 2023
de970cf
feat: add theme config option
IgnaceMaes Dec 10, 2023
e4de39c
docs: document theme option
IgnaceMaes Dec 10, 2023
028bee6
test: add coverage for theme build option
IgnaceMaes Dec 10, 2023
6f5255c
refactor: keep qunit-default as the default
IgnaceMaes May 9, 2024
816dbae
deps: bump qunit-theme-ember
IgnaceMaes May 9, 2024
305fd64
chore: update comment
IgnaceMaes May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion addon/package.json
View file
Open in desktop
Expand Up @@ -43,7 +43,8 @@
"dependencies": {
IgnaceMaes marked this conversation as resolved.
Show resolved Hide resolved
"@embroider/addon-shim": "^1.8.6",
"@embroider/macros": "^1.13.1",
"ember-cli-test-loader": "^3.1.0"
"ember-cli-test-loader": "^3.1.0",
"qunit-theme-ember": "^0.2.0"
},
"devDependencies": {
"@babel/core": "^7.23.2",
Expand Down
2 changes: 2 additions & 0 deletions addon/src/index.js
View file
Open in desktop
Expand Up @@ -7,6 +7,8 @@ if (macroCondition(!getOwnConfig()?.disableContainerStyles)) {
importSync('./test-container-styles.css');
}

importSync('qunit-theme-ember/qunit.css');

export { default as QUnitAdapter, nonTestDoneCallback } from './adapter';
export { loadTests } from './test-loader';

Expand Down
7 changes: 7 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.