Extract test app

[NullVoxPopuli]

Context, Plan, etc: https://gist.github.com/NullVoxPopuli/eafc7dad6547de5e730098498b829e1f

Due to errors discovered in the test-app extraction PR, here: #1061
I'm exploring using pnpm, in part because yarn does not handle peer dependencies correctly, and is not suitable for monorepos with strict resolution behavior.

Requires that these merged first:

• Remove hasEmberVersion #1089
• V2 Addon conversion prep: convert to single-package monorepo. #1060
• Switch to pnpm #1063

Afterwards, the following are unblocked

1. Convert to native package #1064

[ijlee2]

suggestion

After merging the pull requests that you've worked on, in order to update ember-qunit to be a v2 addon, I'd recommend that you update the configuration files such as .eslintignore, .eslintrc.js, .npmignore, etc., by matching the latest code from ember-cli blueprints.

https://github.com/ember-cli/ember-cli/tree/v4.12.1/blueprints/app/files

I think this will help us ensure that we don't develop code based on old standards.

[NullVoxPopuli]

Sure thing. Would like to merge and do a follow up tho

[MelSumner]

Can you create an issue to track the comments in this review before we merge this please? that way we know for sure it won't get lost.

[NullVoxPopuli]

#1092

[ijlee2]

I didn't pass the commit titled Initial extraction. I'd suggest the following steps:

• Get help with merging #1060 and #1063
• Rebase #1062 and #1064 (simplify the commit history)
• Provide more context (e.g. clarify which parts of the code are something that you added, versus which are something that exist already), to help people unfamiliar with the project review the pull requests

What do you think?

[NullVoxPopuli]

Does knowing that the test-app is the addon, copied, help?

Just missed a couple files in the adaptation to a real app is all

[NullVoxPopuli]

Pr updated, you'll want to keep going through the commits tho, because each commit is not a at the level of a whole PR would be. later commits address issues in earlier commits.